retriever condition improve for better response #2441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: website/bot.py
Did you find this useful? React with a 👍 or 👎 |
arkid15r
reviewed
Jul 12, 2024
arkid15r
reviewed
Jul 12, 2024
arkid15r
reviewed
Jul 12, 2024
arkid15r
left a comment
There was a problem hiding this comment.
It's still hard to tell what's k. Is it a limit for search results number?
LGTM
Contributor
Author
@arkid15r , it's actually the retrieval result amount from vector database based on the user question |
DonnieBLT
approved these changes
Jul 15, 2024
Collaborator
DonnieBLT
left a comment
There was a problem hiding this comment.
looks straightforward so approving
Closed
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are very small, but we need them. Now our bot will respond more effectively. I was researching the chain and the vector retrieval part for a few hours. For now, they are fine to use.
@DonnieBLT , can you please this PR for merging