Fix #272: Added See More button in activity panel #279
Conversation
|
issue #272 |
|
Hi @Roboneet -- It causes another issue. Here you go: |
souravbadami
left a comment
There was a problem hiding this comment.
I just added a comment.
|
Also, let's follow this format for the PR title. (Fix #272: Changed positioning in activity panel.). |
souravbadami
left a comment
There was a problem hiding this comment.
I'd suggest few things:
1 - There should be some visible context about the issue before showing the show more link.
2 - Currently, clicking on show more leads to expanding the div and the show more link stays there. Clicking it again causes a bounce action.
Could you please take a look at them ? Thanks!
|
Please review the changes |
souravbadami
left a comment
There was a problem hiding this comment.
@Roboneet -- I have left a few comments. Also, when I click on see more, the div expands and becomes too large in length and when it collapses back -- it loses it's original height. Have you tested it manually ? It would be great to retain those changes.
website/static/js/activity.js
Outdated
| } | ||
|
|
||
|
|
||
| }) No newline at end of file |
There was a problem hiding this comment.
Add a line ending here.
| @@ -0,0 +1,50 @@ | |||
| $(document).ready(function(){ | |||
There was a problem hiding this comment.
Could you please remove the unnecessary lines in the file ?
website/static/css/activity.css
Outdated
| @@ -1,30 +1,74 @@ | |||
| .activity-strip-section >img{ | |||
There was a problem hiding this comment.
As we are refactoring the code base, It would be great if you could replace the tabs with spaces and follow the styling rule similar to website/static/css/main.css.
|
@souravbadami , Is it okay now ? |
|
Looks good! Can you fix the merge conflict ? |
No description provided.