Added number of comments per issues on issue page #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souravbadami
suggested changes
Jun 15, 2017
Collaborator
souravbadami
left a comment
There was a problem hiding this comment.
Hi @farziengineer -- I've done a first pass. I think, we can extend this to the homepage as well. What do you think ?
website/static/css/style.css
Outdated
| position:absolute; | ||
| bottom:10px; | ||
| left:500px; | ||
| } |
Collaborator
There was a problem hiding this comment.
Add a new line here at the end.
Contributor
Author
There was a problem hiding this comment.
After the brace "}" ? Purpose? Is it about clarity. Just curious.
website/templates/domain.html
Outdated
| <em>{{ activity.created|timesince }} ago</em> | ||
| </span> | ||
|
|
||
| <a class="comment_link" href="{{activity.get_absolute_url }}#comments_form"> |
Collaborator
There was a problem hiding this comment.
Remove the single space after <a.
Contributor
Author
|
Sure why not. I'll do a fix |
website/templates/_activity.html
Outdated
| {% load gravatar %} | ||
| <div class="list-group-item activity-strip"> | ||
| <div class="activity-strip-section"> | ||
| <a class="comment_link" href="{{activity.target.get_absolute_url }}#comments_form">{{ activity.target.comments.all|length }} comments</a> |
Collaborator
There was a problem hiding this comment.
Remove the single space after <a.
Collaborator
|
@farziengineer -- This looks good. I have added some additional comments on the thread. We can merge this once you address them. |
souravbadami
approved these changes
Jun 15, 2017
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* Added number of comments per issues on issue page * Added number of comments on issues on homepage * Removed lines from html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the issues page would include the number of comments on each issues ,and clicking on each link would lead to the respective issue.
