Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DShenkle
Copy link
Contributor

@DShenkle DShenkle commented Oct 7, 2021

  • [*] Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • [N/A] If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • [*] Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • [*] Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • [*] Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • [*] Your changes follow the existing coding style
  • [*] If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • [*] You have tested your changes (please state how!) - ideally you
    have added unit tests
  • [*] You have run the existing unit tests against your changes and
    nothing broke
  • [*] You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

  • Changing login error message from 'Incorrect username or password.' to 'Incorrect username or password. Hint: Both are case sensitive!'

How was it tested? How can it be tested by the reviewer?

  • Run octoprint
  • Enter incorrect credentials
  • Verify 'Incorrect username or password. Hint: Both are case sensitive!' message is shown
  • Enter correct credentials login is successful

Any background context you want to provide?

N/A

What are the relevant tickets if any?

#4227

Screenshots (if appropriate)

image

Further notes

N/A

@github-actions github-actions bot added targets dev The PR targets the dev branch approved Issue has been approved by the bot or manually for further processing labels Oct 7, 2021
<h2 class="form-signin-heading" data-test-id="login-title">{{ _('Please log in') }}</h2>

<div id="login-error" class="alert alert-error" data-test-id="login-error">{{ _('Incorrect username or password.') }}</div>
<div id="login-error" class="alert alert-error" data-test-id="login-error">{{ _('Incorrect username or password. Hint: Both are case sensitive!') }}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foosel, would it make more sense to split these two sentences, so that at least the first sentence will still be translated properly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence will still be translated if translation packs are updated to add it in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, what @cp2004 says. Translations have to be updated with every release anyhow, and I'd rather not start micromanage them for maximum reusability 😅

@foosel foosel merged commit 45f115a into OctoPrint:maintenance Oct 8, 2021
@foosel
Copy link
Member

foosel commented Oct 8, 2021

Thank you @DShenkle! ✨

@foosel foosel added this to the 1.8.0 milestone Oct 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Issue has been approved by the bot or manually for further processing hacktoberfest-accepted targets dev The PR targets the dev branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants