Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove success toast when adding to watchlist in Market v2 OK-44738 #8731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: x
Choose a base branch
from
Open

chore: remove success toast when adding to watchlist in Market v2 OK-44738 #8731

wants to merge 2 commits into from
+0 −6

Conversation

limichange
Copy link
Contributor

@limichange limichange commented Oct 22, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Watchlist notifications updated: Success notifications have been removed when adding items to your watchlist. Error handling and error notifications remain fully operational to keep you informed of any issues.

@limichange limichange enabled auto-merge (squash) October 22, 2025 04:21
@revan-zhang
Copy link
Contributor

revan-zhang commented Oct 22, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Licenses 0 0 0 0 0 issues
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025 •
edited
Loading

Walkthrough

Removed the success toast notification from the addIntoWatchListV2 function. Error handling remains unchanged. The change applies to both desktop and mobile environments.

Changes

Cohort / File(s) Summary
Watchlist notification removal
packages/kit/src/views/Market/components/watchListHooksV2.ts		 Deleted user-facing success toast after items are added to watchlist

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "chore: remove success toast when adding to watchlist in Market v2 OK-44738" is clear, specific, and directly related to the main change. It accurately describes the primary action—removing the success toast notification—and specifies the context (Market v2) and issue number. The title aligns well with the summary showing removal of the user-facing success Toast in addIntoWatchListV2.
Linked Issues Check ✅ Passed The code change directly addresses the linked issue OK-44738, which requires removing the success toast notification from the Market watchlist feature. The PR removes the user-facing success Toast in addIntoWatchListV2 while preserving error handling, which aligns with the stated objective. Since this is a hook file modification, the change likely applies across both desktop and mobile platforms as required by the issue, though the summary doesn't explicitly confirm dual-platform coverage.
Out of Scope Changes Check ✅ Passed The changes are appropriately scoped to the linked issue requirements. The PR only removes the success toast notification without introducing unrelated modifications like refactoring, dependency updates, or unrelated feature changes. Error handling logic remains intact, and no public API signatures were altered, indicating focused and intentional changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-market-v2-favorite-toast
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fb7872e and 1abd626.

📒 Files selected for processing (1)
  • packages/kit/src/views/Market/components/watchListHooksV2.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/kit/src/views/Market/components/watchListHooksV2.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: lint (20.x)
  • GitHub Check: unittest (20.x)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (java-kotlin)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@originalix originalix originalix approved these changes

@ezailWang ezailWang Awaiting requested review from ezailWang ezailWang is a code owner

@revan-zhang revan-zhang Awaiting requested review from revan-zhang revan-zhang is a code owner

@sidmorizon sidmorizon Awaiting requested review from sidmorizon sidmorizon is a code owner

@huhuanming huhuanming Awaiting requested review from huhuanming huhuanming is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@limichange @revan-zhang @originalix