Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@clayandgen
Copy link
Contributor

Apologies on the formatter -- if you all don't like the "Standard Ruby" formatter, I can remove it. The actual changes are just with the SystemHealthData seed on scope creation.

Related to: https://github.com/OpenC3/cosmos-enterprise/pull/268

@clayandgen clayandgen requested review from jmthomas and ryanmelt June 10, 2025 22:34
@sonarqubecloud
Copy link

@clayandgen clayandgen assigned clayandgen and unassigned clayandgen Jun 10, 2025
@tool_log_retain_time = @tool_log_retain_time.to_i if @tool_log_retain_time
@cleanup_poll_time = @cleanup_poll_time.to_i
super(update: update, force: force, queued: queued)
super
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually had to look this up ... didn't realize super worked this way (it passes all the arguments implicitly)

"cleanup_poll_time" => @cleanup_poll_time,
"command_authority" => @command_authority,
"critical_commanding" => @critical_commanding,
"shard" => @shard}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised no space after { and before } but whatever

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (15bc996) to head (7cfce0c).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/models/scope_model.rb 86.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2133      +/-   ##
==========================================
- Coverage   79.78%   79.77%   -0.02%     
==========================================
  Files         633      633              
  Lines       48026    48029       +3     
  Branches      754      754              
==========================================
- Hits        38317    38314       -3     
- Misses       9626     9632       +6     
  Partials       83       83              
Flag Coverage Δ
python 83.81% <ø> (-0.04%) ⬇️
ruby-api 78.69% <ø> (ø)
ruby-backend 82.99% <86.48%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryanmelt ryanmelt merged commit 085f2e1 into main Jun 12, 2025
29 checks passed
@ryanmelt ryanmelt deleted the feature/system-health branch June 12, 2025 22:21
@jmthomas jmthomas modified the milestones: COSMOS 7, COSMOS 7.0, COSMOS 6.x Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants