-
Notifications
You must be signed in to change notification settings - Fork 56
[System Health Tool] -- Database Seed #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| @tool_log_retain_time = @tool_log_retain_time.to_i if @tool_log_retain_time | ||
| @cleanup_poll_time = @cleanup_poll_time.to_i | ||
| super(update: update, force: force, queued: queued) | ||
| super |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually had to look this up ... didn't realize super worked this way (it passes all the arguments implicitly)
| "cleanup_poll_time" => @cleanup_poll_time, | ||
| "command_authority" => @command_authority, | ||
| "critical_commanding" => @critical_commanding, | ||
| "shard" => @shard} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little surprised no space after { and before } but whatever
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2133 +/- ##
==========================================
- Coverage 79.78% 79.77% -0.02%
==========================================
Files 633 633
Lines 48026 48029 +3
Branches 754 754
==========================================
- Hits 38317 38314 -3
- Misses 9626 9632 +6
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Apologies on the formatter -- if you all don't like the "Standard Ruby" formatter, I can remove it. The actual changes are just with the
SystemHealthDataseed on scope creation.Related to: https://github.com/OpenC3/cosmos-enterprise/pull/268