Fix Classification-Banner and Snackbar relationship | gRPC | playwright #2236
Conversation
clayandgen
commented
Jul 25, 2025
- gRPC 1.74.0 released July 24, removing the "uninstall" in the Dockerfiles that were causing issues
- Update the snackbars in ScriptRunner to respect the classification banners (closes Top banner covers dialog boxes and notifications #2224)
- Update playwright test that was impacting enterprise tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2236 +/- ##
==========================================
+ Coverage 80.23% 80.26% +0.02%
==========================================
Files 638 638
Lines 47628 47628
Branches 745 745
==========================================
+ Hits 38215 38228 +13
+ Misses 9330 9317 -13
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@ryan-pratt doesn't this also have to update Notifications.vue? Or where is the code that automatically catches 404 errors or whatever and puts up that notification?
There was a problem hiding this comment.
Looks good but I want @ryan-pratt to weigh in on whether we need additional changes
Toast.vue already avoids the banners, this PR is g2g other than removing the last remaining |
|