Custom domain items in TlmGrapher #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently a prop. I'll probably change it to a setting in a subsequent commit
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
==========================================
- Coverage 80.00% 79.96% -0.04%
==========================================
Files 641 641
Lines 47966 47966
Branches 744 744
==========================================
- Hits 38375 38356 -19
- Misses 9509 9528 +19
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can we rename domain to xAxis? |
jmthomas
reviewed
Aug 4, 2025
| <target-packet-item-chooser | ||
| v-if="customDomainEnabled && domainItemPacket" | ||
| :initial-target-name="domainItemPacket.targetName" | ||
| :initial-packet-name="domainItemPacket.packetName" |
There was a problem hiding this comment.
We should add initial-item-name and remember the setting
|
Please rename to xAxis. Domain is too scientific and makes me think of domain names. |
ryanmelt
approved these changes
Aug 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft for code sharing purposes