Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update InterfaceModel when changing params #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2025
Merged

Update InterfaceModel when changing params #2267

merged 1 commit into from
Aug 10, 2025

Conversation

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Aug 7, 2025

Test via:

# Ruby interface
puts get_interface("EXAMPLE_INT")
connect_interface("EXAMPLE_INT", "host", 12345)
puts get_interface("EXAMPLE_INT")

# Python interface
puts get_interface("INST2_INT")
connect_interface("INST2_INT", "helper.py")
puts get_interface("INST2_INT")

@codecov
Copy link

codecov bot commented Aug 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.99%. Comparing base (651cf8a) to head (08297cd).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...lib/openc3/microservices/interface_microservice.rb 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2267      +/-   ##
==========================================
- Coverage   80.00%   79.99%   -0.02%     
==========================================
  Files         641      641              
  Lines       47966    47980      +14     
  Branches      744      744              
==========================================
+ Hits        38375    38380       +5     
- Misses       9509     9518       +9     
  Partials       82       82
Flag Coverage Δ
python 83.54% <ø> (-0.02%) ⬇️
ruby-api 84.28% <ø> (ø)
ruby-backend 82.66% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jmthomas jmthomas merged commit b4d5d2e into main Aug 10, 2025
34 of 35 checks passed
@jmthomas jmthomas deleted the update-interface branch August 10, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryan-pratt ryan-pratt ryan-pratt approved these changes

@ryanmelt ryanmelt Awaiting requested review from ryanmelt

@clayandgen clayandgen Awaiting requested review from clayandgen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmthomas @ryan-pratt