Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ryan-pratt
Copy link
Contributor

If this API request returned an error (e.g. you did a cleanup and that running script no longer existed), SR would lock up and you couldn't recover it without hacking up your storage.

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.99%. Comparing base (c61c8c3) to head (1e69a61).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2296   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files         641      641           
  Lines       47980    47980           
  Branches      744      744           
=======================================
+ Hits        38382    38383    +1     
+ Misses       9516     9515    -1     
  Partials       82       82           
Flag Coverage Δ
python 83.55% <ø> (-0.01%) ⬇️
ruby-api 84.28% <ø> (ø)
ruby-backend 82.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me wonder where else we need explicit catch blocks. Do the little SonarQube fix and then it looks good to merge.

@sonarqubecloud
Copy link

@ryan-pratt ryan-pratt merged commit 616d430 into main Aug 22, 2025
28 of 29 checks passed
@ryan-pratt ryan-pratt deleted the bug/running-script-404-locks-sr branch August 22, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants