Thanks to visit codestin.com
Credit goes to github.com

Skip to content

as_json should not pass allow_nan #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2025
Merged

as_json should not pass allow_nan #2372

merged 3 commits into from
Sep 28, 2025

Conversation

@jmthomas
Copy link
Member

No description provided.

@jmthomas jmthomas requested a review from ryanmelt September 19, 2025 23:04
@codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 73.33333% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.86%. Comparing base (f6615cd) to head (fc97c6b).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/script/script_runner.rb 0.00% 9 Missing ⚠️
openc3/lib/openc3/script/web_socket_api.rb 0.00% 7 Missing ⚠️
...cmd-tlm-api/app/controllers/reaction_controller.rb 42.85% 4 Missing ⚠️
...enc3-cosmos-script-runner-api/app/models/script.rb 42.85% 4 Missing ⚠️
openc3/lib/openc3/logs/packet_log_writer.rb 33.33% 4 Missing ⚠️
openc3/lib/openc3/script/metadata.rb 0.00% 4 Missing ⚠️
openc3/lib/openc3/io/json_rpc.rb 0.00% 3 Missing ⚠️
...lib/openc3/microservices/interface_microservice.rb 90.00% 2 Missing ⚠️
openc3/lib/openc3/operators/operator.rb 0.00% 2 Missing ⚠️
openc3/lib/openc3/script/calendar.rb 0.00% 2 Missing ⚠️
... and 17 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
+ Coverage   79.85%   79.86%   +0.01%     
==========================================
  Files         654      654              
  Lines       48766    48766              
  Branches      741      741              
==========================================
+ Hits        38944    38949       +5     
+ Misses       9740     9735       -5     
  Partials       82       82
Flag Coverage Δ
python 82.88% <ø> (+0.02%) ⬆️
ruby-api 84.68% <78.00%> (ø)
ruby-backend 82.70% <72.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.4% Duplication on New Code

See analysis details on SonarQube Cloud

@jmthomas jmthomas merged commit 883c460 into main Sep 28, 2025
31 checks passed
@jmthomas jmthomas deleted the as_json branch September 28, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanmelt ryanmelt ryanmelt approved these changes

@clayandgen clayandgen clayandgen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmthomas @ryanmelt @clayandgen