Union members cannot be optional #4797
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a71f3e to
6255bd8
Compare
780051a to
1d5c4a4
Compare
docs/news.d/union-members.rst
Outdated
| .. news-prs: 4797 | ||
| .. news-start-section: Additions | ||
| - Add support for `@optional` union members. |
There was a problem hiding this comment.
Suggested change
| - Add support for `@optional` union members. | |
| - Add support for ``@optional`` union members. |
There was a problem hiding this comment.
Or probably better as:
Suggested change
| - Add support for `@optional` union members. | |
| - Add support for :ref:`xtypes--optional` union members. |
jrw972
commented
Sep 17, 2024
| @optional TestStruct struct_field; | ||
| }; | ||
|
|
||
| union TestUnion_Octet switch(long) { |
There was a problem hiding this comment.
Use this union in a test to check serialization.
|
Add issue to xtypes spec and link in documentation. |
Problem ------- Union members cannot be marked `@optional`. Solution -------- Add support for `@optional`. This only applies to the C++11 language mapping.
1d5c4a4 to
876046f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Union members cannot be marked
@optional.Solution
Add support for
@optional. This only applies to the C++11 language mapping.