Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Nic84
Copy link

@Nic84 Nic84 commented Oct 9, 2018

Small test while understanding how github works to be able to collaborate with the project.

@fungos fungos self-assigned this Oct 9, 2018
@fungos fungos requested a review from jokker23 October 9, 2018 20:55
@fungos
Copy link

fungos commented Oct 13, 2018

Thank you very much for this contribution!
I would ask you to replace the russian comments by english one, no need to keep the russian there. Can you fix this and the indentation issue (your've used tabs, our sources are space based) and update the PR please?

@Nic84
Copy link
Author

Nic84 commented Oct 13, 2018

fungos, thanks for you answer! Sure, I'll take a look, I'm glad I could help with the project.

@fungos
Copy link

fungos commented Oct 16, 2018

I'll accept as is for now, but please continue translating anything you find and remove russian stuff in the way. Also, attention to the indentation, I'll check a description on how to correctly use clang-format to contribute to the project avoiding these issues.

@fungos fungos merged commit 75d26e3 into OrionUO:master Oct 16, 2018
VladislavVesely pushed a commit to VladislavVesely/OrionUO that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants