perf: Avoid needless path translation #15679
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when arrayFilters is not set.
4079000 to
d4c921d
Compare
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the castArrayFilters function by moving the array validation check to occur earlier in the execution flow. The change prevents unnecessary computations when arrayFilters is not set or not an array.
- Moved the
Array.isArray(arrayFilters)check from the_castArrayFiltershelper function to the maincastArrayFiltersfunction - This avoids calling
query.getUpdate(),updatedPathsByArrayFilter(), and other operations when array filters are not present
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when arrayFilters is not set.