Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Fix when pushing prerelease from main #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ScarletKuro merged 1 commit into from
May 19, 2025
Merged

chore: Fix when pushing prerelease from main #163

ScarletKuro merged 1 commit into from
May 19, 2025

Conversation

@ScarletKuro
Copy link
Contributor

@ScarletKuro ScarletKuro commented May 19, 2025 •
edited
Loading

Fixes: #162

At least I tried it locally, and it's now identifies for me as 9.0.0-rc.1 so I expect it to work in remote as well.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@ScarletKuro ScarletKuro requested a review from a team May 19, 2025 18:29
@ScarletKuro ScarletKuro mentioned this pull request May 19, 2025
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

IT-VBFK
IT-VBFK approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@IT-VBFK IT-VBFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ScarletKuro ScarletKuro added the 🚧 build Issues regarding the NUKE build label May 19, 2025
@github-actions
Copy link

github-actions bot commented May 19, 2025 •
edited
Loading

Test Results

    50 files  ±0      50 suites  ±0   2m 29s ⏱️ -13s
 6 162 tests ±0   6 162 ✅ ±0  0 💤 ±0  0 ❌ ±0 
38 336 runs  ±0  38 336 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit aefb8e7. ± Comparison against base commit df3285a.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented May 19, 2025

Pull Request Test Coverage Report for Build 15120478899

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 97.491%
Totals Coverage Status
Change from base Build 15112996188: -0.006%
Covered Lines: 12479
Relevant Lines: 12659
💛 - Coveralls

@ScarletKuro ScarletKuro merged commit 686b650 into main May 19, 2025
12 checks passed
@ScarletKuro ScarletKuro deleted the fix_push_prerelease branch May 19, 2025 19:12
@cbersch cbersch self-requested a review May 19, 2025 19:12
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Jul 28, 2025
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Aug 5, 2025
Open
This was referenced Sep 29, 2025
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 6, 2025
Closed
This was referenced Oct 20, 2025
Open
Closed
Closed
Closed
Open
Open
Closed
Merged
This was referenced Oct 27, 2025
Merged
Open
This was referenced Nov 3, 2025
Open
Closed
Open
This was referenced Nov 10, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Dec 1, 2025
Merged
This was referenced Dec 15, 2025
Closed
Closed
Open
@dependabot dependabot bot mentioned this pull request Dec 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IT-VBFK IT-VBFK IT-VBFK approved these changes

@cbersch cbersch Awaiting requested review from cbersch

Assignees

No one assigned

Labels

🚧 build Issues regarding the NUKE build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Push of Prerelease 9.0.0-rc.1 failed

4 participants

@ScarletKuro @coveralls @IT-VBFK