Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: clean up the long functions into simpler ones #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

chore: clean up the long functions into simpler ones #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 66 additions & 69 deletions internal/components/network/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,96 +333,93 @@ func GetPrivateEndpointInfoHandler(client *azureclient.AzureClient, cfg *config.
// GetAzNetworkResourcesHandler returns a handler for the az_network_resources command
func GetAzNetworkResourcesHandler(client *azureclient.AzureClient, cfg *config.ConfigData) tools.ResourceHandler {
return tools.ResourceHandlerFunc(func(params map[string]interface{}, _ *config.ConfigData) (string, error) {
// Extract resource_type parameter
resourceType, ok := params["resource_type"].(string)
if !ok {
return "", fmt.Errorf("missing or invalid 'resource_type' parameter")
}

// Validate resource type
if !ValidateNetworkResourceType(resourceType) {
supportedTypes := GetSupportedNetworkResourceTypes()
return "", fmt.Errorf("unsupported resource type: %s. Supported types: %v", resourceType, supportedTypes)
}

// Extract common AKS parameters
subID, rg, clusterName, err := common.ExtractAKSParameters(params)
resourceType, subID, rg, clusterName, err := validateNetworkParams(params)
if err != nil {
return "", err
}

// Handle different resource types
switch resourceType {
case string(ResourceTypeAll):
return handleAllNetworkResources(client, subID, rg, clusterName)
case string(ResourceTypeVNet):
return handleVNetResource(client, subID, rg, clusterName)
case string(ResourceTypeNSG):
return handleNSGResource(client, subID, rg, clusterName)
case string(ResourceTypeRouteTable):
return handleRouteTableResource(client, subID, rg, clusterName)
case string(ResourceTypeSubnet):
return handleSubnetResource(client, subID, rg, clusterName)
case string(ResourceTypeLoadBalancer):
return handleLoadBalancerResource(client, subID, rg, clusterName)
case string(ResourceTypePrivateEndpoint):
return handlePrivateEndpointResource(client, subID, rg, clusterName)
default:
return "", fmt.Errorf("resource type '%s' not implemented", resourceType)
}
// Handle resource type
return handleNetworkResourceType(client, resourceType, subID, rg, clusterName)
})
}

// Helper functions for different resource types

func handleAllNetworkResources(client *azureclient.AzureClient, subID, rg, clusterName string) (string, error) {
result := make(map[string]interface{})

// Get VNet info
if vnetResult, err := handleVNetResource(client, subID, rg, clusterName); err == nil {
result["vnet"] = json.RawMessage(vnetResult)
} else {
result["vnet_error"] = err.Error()
// validateNetworkParams validates network resource parameters
func validateNetworkParams(params map[string]interface{}) (string, string, string, string, error) {
// Extract resource_type parameter
resourceType, ok := params["resource_type"].(string)
if !ok {
return "", "", "", "", fmt.Errorf("missing or invalid 'resource_type' parameter")
}

// Get NSG info
if nsgResult, err := handleNSGResource(client, subID, rg, clusterName); err == nil {
result["nsg"] = json.RawMessage(nsgResult)
} else {
result["nsg_error"] = err.Error()
// Validate resource type
if !ValidateNetworkResourceType(resourceType) {
supportedTypes := GetSupportedNetworkResourceTypes()
return "", "", "", "", fmt.Errorf("unsupported resource type: %s. Supported types: %v", resourceType, supportedTypes)
}

// Get Route Table info
if routeResult, err := handleRouteTableResource(client, subID, rg, clusterName); err == nil {
result["route_table"] = json.RawMessage(routeResult)
} else {
result["route_table_error"] = err.Error()
// Extract common AKS parameters
subID, rg, clusterName, err := common.ExtractAKSParameters(params)
if err != nil {
return "", "", "", "", err
}

// Get Subnet info
if subnetResult, err := handleSubnetResource(client, subID, rg, clusterName); err == nil {
result["subnet"] = json.RawMessage(subnetResult)
} else {
result["subnet_error"] = err.Error()
return resourceType, subID, rg, clusterName, nil
}

// handleNetworkResourceType routes to the appropriate resource handler based on type
func handleNetworkResourceType(client *azureclient.AzureClient, resourceType, subID, rg, clusterName string) (string, error) {
switch resourceType {
case string(ResourceTypeAll):
return handleAllNetworkResources(client, subID, rg, clusterName)
case string(ResourceTypeVNet):
return handleVNetResource(client, subID, rg, clusterName)
case string(ResourceTypeNSG):
return handleNSGResource(client, subID, rg, clusterName)
case string(ResourceTypeRouteTable):
return handleRouteTableResource(client, subID, rg, clusterName)
case string(ResourceTypeSubnet):
return handleSubnetResource(client, subID, rg, clusterName)
case string(ResourceTypeLoadBalancer):
return handleLoadBalancerResource(client, subID, rg, clusterName)
case string(ResourceTypePrivateEndpoint):
return handlePrivateEndpointResource(client, subID, rg, clusterName)
default:
return "", fmt.Errorf("resource type '%s' not implemented", resourceType)
}
}

// Helper functions for different resource types

// Get Load Balancer info
if lbResult, err := handleLoadBalancerResource(client, subID, rg, clusterName); err == nil {
result["load_balancer"] = json.RawMessage(lbResult)
} else {
result["load_balancer_error"] = err.Error()
func handleAllNetworkResources(client *azureclient.AzureClient, subID, rg, clusterName string) (string, error) {
result := make(map[string]interface{})

// Collect results and errors for each resource type
resourceHandlers := map[string]func(*azureclient.AzureClient, string, string, string) (string, error){
"vnet": handleVNetResource,
"nsg": handleNSGResource,
"route_table": handleRouteTableResource,
"subnet": handleSubnetResource,
"load_balancer": handleLoadBalancerResource,
"private_endpoint": handlePrivateEndpointResource,
}

// Get Private Endpoint info
if peResult, err := handlePrivateEndpointResource(client, subID, rg, clusterName); err == nil {
result["private_endpoint"] = json.RawMessage(peResult)
} else {
result["private_endpoint_error"] = err.Error()
// Process each resource type and preserve error context
for resourceType, handler := range resourceHandlers {
resourceResult, err := handler(client, subID, rg, clusterName)
if err != nil {
// Preserve original error context and type for debugging
result[resourceType+"_error"] = map[string]interface{}{
"message": err.Error(),
"type": fmt.Sprintf("%T", err),
}
} else {
result[resourceType] = json.RawMessage(resourceResult)
}
}

resultJSON, err := json.MarshalIndent(result, "", " ")
if err != nil {
return "", fmt.Errorf("failed to marshal result to JSON: %v", err)
return "", fmt.Errorf("failed to marshal result to JSON: %w", err)
}

return string(resultJSON), nil
Expand Down
Loading