Conversation
Member
|
this is very cool |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive telemetry support to the AKS MCP service, enabling the collection of operational data through OpenTelemetry Protocol (OTLP) traces and Azure Application Insights. The telemetry system tracks tool invocations and service startup events while providing privacy controls through environment variable configuration.
Key changes include:
- Implementation of a telemetry service with support for OTLP traces and Application Insights
- Integration of telemetry tracking into existing tool handlers
- Configuration options for telemetry providers and privacy controls
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/telemetry/service.go | Core telemetry service implementation with OTLP and Application Insights support |
| internal/telemetry/config.go | Telemetry configuration management with privacy controls |
| internal/telemetry/config_test.go | Comprehensive test coverage for telemetry configuration |
| internal/tools/handler.go | Integration of telemetry tracking into tool invocation handlers |
| internal/config/config.go | Addition of telemetry initialization and OTLP endpoint configuration |
| cmd/aks-mcp/main.go | Main application integration with graceful telemetry shutdown |
| go.mod | Addition of required telemetry dependencies |
| README.md | Documentation of telemetry features and privacy controls |
gossion
approved these changes
Aug 12, 2025
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add telemetry and OTLP traces.