Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the compute operations functionality to use a unified approach, consolidating multiple individual VMSS command tools into a single, comprehensive az_compute_operations tool. This improves the API design by providing consistent access to both VM and VMSS operations through a single interface.
Key Changes
- Replaced multiple individual VMSS command registrations with a single unified compute operations tool
- Implemented access level validation through operation-level checks rather than tool registration filtering
- Added comprehensive operation mapping and validation for both VMs and VMSS resources
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/server/server.go | Simplified compute component registration to use single unified tool instead of multiple individual tools |
| internal/server/server_test.go | Updated test expectations to reflect unified tool approach with consistent tool counts across access levels |
| internal/components/compute/registry.go | Removed deprecated VMSS command registration functions that are no longer needed |
| internal/components/compute/azcommands.go | Complete rewrite to implement unified operations with comprehensive operation mapping and access validation |
| internal/components/compute/executor.go | New executor implementation for handling unified compute operations with enhanced error messaging |
| internal/components/compute/unified_test.go | Comprehensive test suite for the new unified operations approach |
feiskyer
reviewed
Aug 14, 2025
feiskyer
reviewed
Aug 14, 2025
0e305e2 to
41b1910
Compare
41b1910 to
fecab94
Compare
feiskyer
approved these changes
Aug 14, 2025
Member
feiskyer
left a comment
There was a problem hiding this comment.
Thanks addressing the comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.