Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sihbher
Copy link
Contributor

@sihbher sihbher commented Oct 4, 2023

Solve this issue:

image

@sihbher sihbher requested a review from jfaurskov October 4, 2023 14:35
@jfaurskov jfaurskov requested a review from kohei3110 October 5, 2023 19:47
Copy link
Collaborator

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sihbher, question though. Does this remove the role assignment from the module all up or was it a duplicate or something?

@sihbher
Copy link
Contributor Author

sihbher commented Oct 6, 2023

Great work @sihbher, question though. Does this remove the role assignment from the module all up or was it a duplicate or something?

Hey @jfaurskov
I discussed this change with @kohei3110. in summary, it does not make sense to add the user that is running the TF script as "Contributor" to the resource group, because it must have at least that permission in the beginning to be able to create the resource group, so it will be added automatically at the creation time. All other resource assignments are still applied thou.

Copy link
Collaborator

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov jfaurskov merged commit 355f36c into main Oct 6, 2023
@sihbher sihbher deleted the RoleAssignmentExistsFix branch October 6, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants