Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixing parameters #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fixing parameters #14

merged 2 commits into from
Oct 9, 2023

Conversation

@sihbher
Copy link
Contributor

@sihbher sihbher commented Oct 5, 2023

Resolves #13

@sihbher sihbher requested a review from kohei3110 October 5, 2023 00:51
kohei3110
kohei3110 suggested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@kohei3110 kohei3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sihbher

Great work, Gerardo-san! I added some minor comments. During your free time, can you check these?

kohei3110
kohei3110 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@kohei3110 kohei3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kohei3110 kohei3110 merged commit f759b39 into main Oct 9, 2023
@kohei3110 kohei3110 deleted the fix/parameters branch October 13, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kohei3110 kohei3110 kohei3110 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add parameter file

2 participants

@sihbher @kohei3110