Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dbenn
Copy link
Collaborator

@dbenn dbenn commented Nov 25, 2025

Hi @mpyat2 Please look over this. I've just added a notifier to tell the load from AID dialog to update its star groups/stars.

There are actions failures (UTs) at the moment too which I'm tracking down. Not sure yet whether related to this change. Unlikely. VSXWebService* related.

@dbenn dbenn requested a review from mpyat2 November 25, 2025 13:57
@dbenn dbenn self-assigned this Nov 25, 2025
@dbenn dbenn added the bug Something isn't working label Nov 25, 2025
@mpyat2
Copy link
Collaborator

mpyat2 commented Nov 27, 2025

Hi David,
It does not work for me.
image

  1. Run VStar
  2. New Star from AAVSO database...
  3. Load any star data (for example, V965 Cep)
  4. Preferences->Star Groups
  5. Add Group "01 Test"
  6. Add Star "SZ Lyn"
  7. OK to close Preferences
  8. New Star from AAVSO database...
  9. There is no "01 Test" group on the list

@dbenn
Copy link
Collaborator Author

dbenn commented Nov 27, 2025

Very odd. I can reproduce this, yet it worked with another "test" group before I created the PR. The group appears after VStar has started.

@dbenn
Copy link
Collaborator Author

dbenn commented Dec 1, 2025

Okay, please try with latest commit @mpyat2

Above scenario now works for me along with another I tried. Added refresh call at showDialog() time.

@mpyat2
Copy link
Collaborator

mpyat2 commented Dec 1, 2025

Okay, please try with latest commit @mpyat2

Above scenario now works for me along with another I tried. Added refresh call at showDialog() time.

It works for me too! It seems everything is OK now.

@dbenn dbenn merged commit d9830b2 into master Dec 2, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Star Groups Preference updates should not require reboot to appear in New Star from AID dialog

3 participants