• Frontend/src/context/AuthContext.tsx
  • Imported useLocation hook (line 8).
  • Added location state using useLocation (line 28).
  • Modified onAuthStateChange listener to prevent automatic navigation to /dashboard if the user is on the /reset-password page or the event is PASSWORD_RECOVERY (lines 38-42).
  • Updated the dependency array for the useEffect hook to include location.pathname and navigate (line 49).
• Frontend/src/pages/ForgotPassword.tsx
  • Imported supabase utility (line 4).
  • Added showSignupPrompt state to manage displaying a prompt if the email is not found (line 11).
  • Modified handleSubmit to check for email existence in the users table before initiating the password reset flow (lines 21-31).
  • If email is not found, set showSignupPrompt to true and return (lines 27-30).
  • Called supabase.auth.resetPasswordForEmail with a redirectTo URL pointing to /reset-password (lines 32-34).
  • Updated error handling to catch and display specific Supabase errors (line 38).
  • Added conditional rendering for the signup prompt message below the error message (lines 108-112).
  • Updated the email input placeholder to mention case sensitivity (line 129).
• Frontend/src/pages/ResetPassword.tsx
  • Imported useEffect and useRef hooks (line 1).
  • Imported supabase utility (line 5).
  • Removed placeholder token variable (line 10).
  • Added progress state and progressRef for the redirect timer animation (lines 17-18).
  • Added a useEffect hook to handle the redirect timer and progress bar animation after a successful password reset (lines 25-42).
  • Modified handleSubmit to call supabase.auth.updateUser with the new password (line 56).
  • Updated error handling to catch and display specific Supabase errors (line 60).
  • Changed the conditional rendering logic to show the success message and progress bar when isSuccess is true (line 92).
  • Updated the success message UI to display 'Password Changed Successfully' and the redirecting message with the progress bar (lines 109-120).
  • Removed the 'Invalid or Expired Link' state and UI.
• Frontend/src/pages/Signup.tsx
  • Added username field to the formData state (line 13).
  • Modified handleSubmit to extract the username from formData (line 45).
  • Implemented a check for username uniqueness in the users table before attempting to sign up (lines 47-57).
  • If the username exists, set an error message and return (lines 53-56).
  • Updated the user insertion logic to insert into the users table instead of profiles (lines 73-89).
  • Included username, email, password_hash (as a placeholder), role, and other default fields in the users table insertion (lines 79-88).
  • Changed the navigation path after successful signup to /BasicDetails/${accountType} (line 98).
  • Added a new input field for 'Username' in the signup form UI (lines 197-214).

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Frontend/src/pages/ResetPassword.tsx (1)

25-42: Consider extracting magic numbers and adding session validation.

The progress calculation uses magic numbers that could be clearer, and there's no validation that the user has a valid session.

+ const REDIRECT_DELAY_SECONDS = 3;
+ const PROGRESS_INTERVAL_MS = 100;

  useEffect(() => {
    if (isSuccess) {
      setProgress(0);
      progressRef.current = setInterval(() => {
        setProgress((prev) => {
          if (prev >= 100) {
            if (progressRef.current) clearInterval(progressRef.current);
            router("/dashboard");
            return 100;
          }
-         return prev + (100 / 30); // 3 seconds, 100ms interval
+         return prev + (100 / (REDIRECT_DELAY_SECONDS * 1000 / PROGRESS_INTERVAL_MS));
        });
-     }, 100);
+     }, PROGRESS_INTERVAL_MS);
    }

Also consider adding session validation:

useEffect(() => {
  // Verify user has valid session for password reset
  supabase.auth.getSession().then(({ data }) => {
    if (!data.session) {
      setError("Invalid or expired reset link. Please request a new one.");
    }
  });
}, []);

Frontend/src/pages/ForgotPassword.tsx (1)

129-129: Consider removing "CASE sensitive" from email placeholder.

Most email systems and Supabase are case-insensitive for email addresses. The "CASE sensitive" note might confuse users unnecessarily.

-                        placeholder="[email protected] (CASE sensitive)"
+                        placeholder="[email protected]"

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Frontend/src/pages/Signup.tsx (1)

128-143: ⚠️ Potential issue

Google OAuth signup lacks username handling.

The Google OAuth signup flow doesn't account for the new username requirement. Users signing up via Google won't have a username set, which could cause issues in the application.

Consider implementing a username selection step for OAuth users:

  const handleGoogleSignUp = async () => {
    const { data, error } = await supabase.auth.signInWithOAuth({
      provider: "google",
+     options: {
+       redirectTo: `${window.location.origin}/complete-profile`
+     }
    });

    if (error) {
      console.log("Google login error", error);
      return;
    }

-   supabase.auth.onAuthStateChange((event, session) => {
-     if (session) {
-       login();
-     }
-   });
+   // Handle OAuth completion in a separate component/page
+   // where users can set their username
  };

Frontend/src/pages/Signup.tsx (4)

68-78: Consider implementing case-insensitive username uniqueness check.

The current implementation checks for exact username matches, but usernames are typically treated as case-insensitive to prevent confusion (e.g., "User1" and "user1" should be considered the same).

This aligns with the previous review comment about case sensitivity handling.

---

96-110: Remove password_hash field and let database handle timestamps.

The user insertion includes problematic fields that should be addressed:

This matches the previous review comments about password_hash and timestamp handling concerns.

---

227-239: Add HTML validation attributes to username input.

The username input field lacks native HTML validation attributes that would provide immediate browser-level feedback.

This was addressed in a previous review comment about adding validation attributes like pattern, minLength, and maxLength.

---

120-120: Validate accountType before navigation.

This was previously identified as needing validation to prevent navigation to invalid routes.

Frontend/src/pages/Signup.tsx (2)

37-44: Username validation regex could be more restrictive for better UX.

The current regex allows usernames like a__ (letter followed by underscores) which might not provide the best user experience. Consider requiring at least one alphanumeric character after the initial letter.

-  const regex = /^[a-zA-Z][a-zA-Z0-9_]{2,19}$/;
+  const regex = /^[a-zA-Z][a-zA-Z0-9]*[a-zA-Z0-9_]*[a-zA-Z0-9]$|^[a-zA-Z][a-zA-Z0-9]{1,18}$/;

Alternatively, use a simpler approach that prevents consecutive underscores and trailing underscores:

-  const regex = /^[a-zA-Z][a-zA-Z0-9_]{2,19}$/;
+  const regex = /^[a-zA-Z](?!.*__)[a-zA-Z0-9_]{2,18}[a-zA-Z0-9]$/;

---

57-63: Improve error handling for validation feedback.

The validation check prevents submission but doesn't reset the loading state consistently with the username uniqueness check pattern.

Consider extracting the validation and loading state reset into a helper function:

    // Validate username before submitting
    const usernameValidation = validateUsername(formData.username);
    if (usernameValidation) {
      setUsernameError(usernameValidation);
      setIsLoading(false);
      return;
    }
+   // Clear any previous username errors
+   setUsernameError("");

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro