Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add safeguard to prevent moss from eating your current operating system #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add safeguard to prevent moss from eating your current operating system #423

wants to merge 1 commit into from
+24 −3

Conversation

@cameronbraid
Copy link

Only provide a default value for "root" global argument if the current system is identified as a serpent os.

Currently uses the MACHTYPE env for detection

Manually tested on a arch system :

> moss list installed
Error: args: Root directory is required, but not provided

And when we fake then env we get an expected error

> MACHTYPE=serpent moss list installed
Error: list: client: db: diesel connection: Unable to open the database file

@cameronbraid
add safeguard to prevent moss from eating your current operating system
289448b 
Only provide a default value for "root" global argument if the current system is identified as a serpent os.

Currently uses the MACHTYPE env for detection
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Quackdoc
Copy link

Would it not be better to check /usr/lib/os-release ? I know MACHTYPE can sometimes change depending on shell.

also this seems like it would limit moss to working on serpent as the system package manager. perhaps there could be a better way of doing this. Could this be set via config or something?

@cameronbraid
Copy link
Author

What about changing the default back to / and add an assertion that "$root/.moss" folder is present

@cameronbraid
Copy link
Author

cameronbraid commented Feb 13, 2025 •
edited
Loading

Although, this might suggest that a separate moss init command should be added as the only means to create a .moss installation... then all other commands could fail if the directory its not a valid installation

@ermo
Copy link
Member

ermo commented Feb 14, 2025 •
edited
Loading

The idea of having a well thought out moss init feature that checks for the relevant preconditions etc. sounds compelling.

This migh also tie nicely into potentially setting up the proper minimum SELinux policy for /.moss and /usr in the future.

@ermo ermo added this to the alpha1 milestone Apr 17, 2025
@ermo
Copy link
Member

ermo commented Apr 17, 2025

@cameronbraid You still up for working on this?

@ermo ermo removed this from the alpha1 milestone Apr 17, 2025
@ermo ermo added this to the alpha2 milestone May 8, 2025
@ermo ermo added type: user experience Will make for a nicer user experience priority: could have labels May 27, 2025
@ermo ermo marked this pull request as draft June 11, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikeycode ikeycode Awaiting requested review from ikeycode ikeycode is a code owner

@ermo ermo Awaiting requested review from ermo ermo is a code owner

@tarkah tarkah Awaiting requested review from tarkah tarkah is a code owner

@jplatte jplatte Awaiting requested review from jplatte jplatte will be requested when the pull request is marked ready for review jplatte is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

priority: could have type: user experience Will make for a nicer user experience

Projects

None yet

Milestone

alpha2

Development

Successfully merging this pull request may close these issues.

4 participants

@cameronbraid @CLAassistant @Quackdoc @ermo