Ensure async runtime cannot outlive scope of running a future #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed a place where we invoke
container
while the async runtime is kept alive, inpostblit
.Having a global runtime without a clear guarantee around lifetime makes it very easy to miss this. We can fix this in two ways, both eliminate the use of a global static runtime:
block_on
always construct a single use runtime that is dropped before returning the completed taskI've chosen the latter for simplicity, even if its less efficient. Its impossible to misuse. The first approach still runs risk of someone calling into
container
from some nested function that isn't aware an activeruntime
is held across its call site. This means that unless we pass ownership of runtime into and out of every function, we can easily lose track and hit this bug again.