Added geminox manufacturer and added missing sensors for esphome#45
Added geminox manufacturer and added missing sensors for esphome#45Alexwijn merged 2 commits intoAlexwijn:developfrom
Conversation
|
Thanks! Could you adjust the pull request to only add the manufacturer? The ESPHome integration is still in its early stages, and we discovered that the unique ID is based on the name you assign to it, which causes issues for us. We are still investigating an appropriate solution for this. |
|
That is certainly possible, however the missing sensors does cause the Boiler Current Power sensor to be unavailable, I would rather not have to maintain them locally until the setup flow is fixed, but I can of course remove them if you do not want them in right now. Regarding the manufacturer, @sergeantd83 just pointed out in discord, that 4 is actually Siemens and are used by multiple manufacturers, so this is the proposal: Regarding the setup flow, for now I just named them the way that SAT expects them, but I can see that, that is not super user friendly. Let me know what you think. |
My geminox gas boiler returns 4 as the ID3:LB value.
I added 2 missing sensors for the esphome implementation, they are based on the default names in olegtarasov's branch, but I guess we will need to clean up the naming when the sensors are added in an official esphome release anyway.