Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Add MasterWindowFlagsHidden#853

Merged
gucio321 merged 3 commits intoAllenDang:masterfrom
cjbrigato:patch-1
Sep 21, 2024
Merged

Add MasterWindowFlagsHidden#853
gucio321 merged 3 commits intoAllenDang:masterfrom
cjbrigato:patch-1

Conversation

@cjbrigato
Copy link
Contributor

@cjbrigato cjbrigato commented Sep 21, 2024 •
edited
Loading

Update MasterWindow witj GLFWWindowsFlagsVisible access

It is used by cases where we really don't want any native window decoration.
It usually implies this MasterWindow preambule

	imgui.CreateContext()
	io := imgui.CurrentIO()
	io.SetConfigViewportsNoAutoMerge(true)
	io.SetConfigViewportsNoDefaultParent(true)
	wnd := g.NewMasterWindow("Client", 1, 1,g.MasterWindowFlagsHidden|g.MasterWindowFlagsFrameless)
	wnd.Run(loop)

@cjbrigato
Add MasterWindowFlagsHidden
6c6318b 
Update MasterWindow witj GLFWWindowsFlagsVisible access
gucio321
gucio321 approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@gucio321 gucio321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@gucio321
Copy link
Collaborator

gucio321 commented Sep 21, 2024

@cjbrigato golangci-lint had some problems could you fix

@cjbrigato
Copy link
Contributor Author

cjbrigato commented Sep 21, 2024 •
edited
Loading

@cjbrigato golangci-lint had some problems could you fix

I'll do it in few hours thanks

@cjbrigato
Update MasterWindow.go
793a7b6 
Fixes golangci-lint for godot
@cjbrigato
Copy link
Contributor Author

cjbrigato commented Sep 21, 2024

@gucio321 should pass the linting now

@cjbrigato
Update MasterWindow.go
799bf78 
Fix linting again
@cjbrigato
Copy link
Contributor Author

cjbrigato commented Sep 21, 2024

@gucio321 the linter is hardcore, sorry. Fixed now.

@gucio321 gucio321 merged commit b7cd462 into AllenDang:master Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gucio321 gucio321 gucio321 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjbrigato @gucio321