Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: ⚡ Improve input and output converters #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 23, 2022
Merged

feat: ⚡ Improve input and output converters #527

merged 9 commits into from
Dec 23, 2022

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Dec 23, 2022 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Maintenance & Security python Pull requests that update Python code labels Dec 23, 2022
@Anselmoo Anselmoo changed the title Anselmoo/issue329 feat: ⚡ Improve input and output converters Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022 •
edited
Loading

Codecov Report

Merging #527 (6f0ffee) into main (2af7d0d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
+ Coverage   99.44%   99.48%   +0.04%     
==========================================
  Files          28       32       +4     
  Lines        2476     2657     +181     
==========================================
+ Hits         2462     2643     +181     
  Misses         14       14
Impacted Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/api/file_model.py 100.00% <100.00%> (ø)
spectrafit/api/test/test_file_model.py 100.00% <100.00%> (ø)
spectrafit/plugins/converter.py 100.00% <100.00%> (ø)
spectrafit/plugins/data_converter.py 100.00% <100.00%> (ø)
spectrafit/plugins/file_converter.py 100.00% <100.00%> (ø)
spectrafit/plugins/test/test_converter.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 23, 2022 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 4.55%.

Quality metrics Before After Change
Complexity 1.02 ⭐ 0.26 ⭐ -0.76 👍
Method Length 53.00 ⭐ 45.14 ⭐ -7.86 👍
Working memory 5.12 ⭐ 4.48 ⭐ -0.64 👍
Quality 83.03% ⭐ 87.58% ⭐ 4.55% 👍
Other metrics Before After Change
Lines 168 305 137
Changed files Quality Before Quality After Quality Change
spectrafit/__init__.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/plugins/converter.py 71.94% 🙂 98.02% ⭐ 26.08% 👍
spectrafit/plugins/test/test_converter.py 88.17% ⭐ 87.12% ⭐ -1.05% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/plugins/test/test_converter.py test_conversion 2 ⭐ 127 😞 7 🙂 70.14% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo merged commit de11794 into main Dec 23, 2022
@Anselmoo Anselmoo deleted the Anselmoo/issue329 branch December 23, 2022 17:48
@Anselmoo Anselmoo restored the Anselmoo/issue329 branch December 23, 2022 17:52
@Anselmoo Anselmoo deleted the Anselmoo/issue329 branch December 23, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation maintenance Maintenance & Security python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Auto-detection of regular file formats

1 participant

@Anselmoo