Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: 🐛 Correct typo in args_minimizer #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: 🐛 Correct typo in args_minimizer #604

merged 1 commit into from
Feb 14, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Feb 14, 2023 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 14, 2023

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 7.60 ⭐ 7.60 ⭐ 0.00
Method Length 84.84 🙂 84.84 🙂 0.00
Working memory 10.40 😞 10.40 😞 0.00
Quality 59.31% 🙂 59.31% 🙂 0.00%
Other metrics Before After Change
Lines 1157 1157 0
Changed files Quality Before Quality After Quality Change
spectrafit/models.py 59.31% 🙂 59.31% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/models.py calculated_model 20 😞 320 ⛔ 17 ⛔ 24.72% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py SolverModels.solve_global_fitting 15 🙂 314 ⛔ 19 ⛔ 27.10% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py SolverModels.solve_local_fitting 15 🙂 250 ⛔ 18 ⛔ 30.36% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py ModelParameters.define_parameters_auto 15 🙂 650 ⛔ 10 😞 35.78% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py AutoPeakDetection.initialize_peak_detection 3 ⭐ 262 ⛔ 12 😞 48.08% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added documentation Improvements or additions to documentation python Pull requests that update Python code labels Feb 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 14, 2023 •
edited
Loading

Codecov Report

Merging #604 (e2e8cb1) into main (6790494) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #604   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         3521      3521           
=========================================
  Hits          3521      3521
Impacted Files Coverage Δ
spectrafit/models.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anselmoo Anselmoo merged commit 782b4c3 into main Feb 14, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue602 branch February 14, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Fully Support of Global Fit for Jupyter Notebook

1 participant

@Anselmoo