Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: ✨ Add global fitting plots #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2023
Merged

feat: ✨ Add global fitting plots #608

merged 3 commits into from
Feb 17, 2023

Conversation

@Anselmoo
Copy link
Owner

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@github-actions github-actions bot added the python Pull requests that update Python code label Feb 16, 2023
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 16, 2023 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 0.79 ⭐ 0.78 ⭐ -0.01 👍
Method Length 57.46 ⭐ 57.85 ⭐ 0.39 👎
Working memory 6.83 🙂 6.79 🙂 -0.04 👍
Quality 81.14% ⭐ 81.20% ⭐ 0.06% 👍
Other metrics Before After Change
Lines 1879 1956 77
Changed files Quality Before Quality After Quality Change
spectrafit/plugins/notebook.py 75.43% ⭐ 75.38% ⭐ -0.05% 👎
spectrafit/plugins/test/test_notebook.py 85.85% ⭐ 85.84% ⭐ -0.01% 👎
spectrafit/test/test_input.py 85.09% ⭐ 85.17% ⭐ 0.08% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/plugins/notebook.py SpectraFitNotebook.__init__ 3 ⭐ 358 ⛔ 43 ⛔ 32.44% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/plugins/notebook.py SpectraFitNotebook.solver_model 8 ⭐ 180 😞 14 😞 45.57% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/plugins/notebook.py DataFramePlot.plot_2dataframes 6 ⭐ 424 ⛔ 8 🙂 49.11% 😞 Try splitting into smaller methods
spectrafit/plugins/notebook.py DataFramePlot.plot_metric 0 ⭐ 195 😞 8 🙂 63.06% 🙂 Try splitting into smaller methods
spectrafit/plugins/notebook.py ExportReport.__init__ 0 ⭐ 90 🙂 11 😞 68.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 16, 2023 •
edited
Loading

Codecov Report

Merging #608 (f4a38be) into main (d307745) will increase coverage by 3.05%.
The diff coverage is 100.00%.

❗ Current head f4a38be differs from pull request most recent head f7c154e. Consider uploading reports for the commit f7c154e to get more accurate results

@@             Coverage Diff             @@
##             main      #608      +/-   ##
===========================================
+ Coverage   96.96%   100.00%   +3.05%     
===========================================
  Files          39        40       +1     
  Lines        3519      3553      +34     
===========================================
+ Hits         3412      3553     +141     
+ Misses        107         0     -107
Impacted Files Coverage Δ
spectrafit/plugins/notebook.py 100.00% <100.00%> (+3.70%) ⬆️
spectrafit/plugins/test/test_notebook.py 100.00% <100.00%> (+13.21%) ⬆️
spectrafit/test/test_input.py 100.00% <100.00%> (+21.63%) ⬆️
spectrafit/spectrafit.py 100.00% <0.00%> (ø)
spectrafit/__init__.py 100.00% <0.00%> (ø)
spectrafit/test/test_models.py 100.00% <0.00%> (+0.90%) ⬆️
spectrafit/models.py 100.00% <0.00%> (+4.00%) ⬆️
spectrafit/report.py 100.00% <0.00%> (+9.60%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anselmoo Anselmoo merged commit 824705b into main Feb 17, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue606 branch February 17, 2023 06:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo added enhancement New feature or request codespaces Everything connected to GitHub's Codespaces labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codespaces Everything connected to GitHub's Codespaces enhancement New feature or request python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Plotly Plots for Global Fitting

1 participant

@Anselmoo