Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ✨ Add cumulative gaussian #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 20, 2023
Merged

fix: ✨ Add cumulative gaussian #611

merged 9 commits into from
Feb 20, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Feb 17, 2023 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 17, 2023 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 8.70%.

Quality metrics Before After Change
Complexity 4.30 ⭐ 1.92 ⭐ -2.38 👍
Method Length 83.29 🙂 73.86 🙂 -9.43 👍
Working memory 8.08 🙂 6.07 ⭐ -2.01 👍
Quality 70.02% 🙂 78.72% ⭐ 8.70% 👍
Other metrics Before After Change
Lines 2135 2231 96
Changed files Quality Before Quality After Quality Change
spectrafit/__init__.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/models.py 59.31% 🙂 74.15% 🙂 14.84% 👍
spectrafit/test/test_models.py 83.94% ⭐ 83.78% ⭐ -0.16% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/models.py ModelParameters.define_parameters_auto 15 🙂 650 ⛔ 10 😞 35.78% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/test/test_models.py TestModelParametersSolver.test_all_model_local 0 ⭐ 522 ⛔ 8 🙂 54.40% 🙂 Try splitting into smaller methods
spectrafit/test/test_models.py TestModelParametersSolver.test_all_model_global 0 ⭐ 521 ⛔ 8 🙂 54.40% 🙂 Try splitting into smaller methods
spectrafit/models.py DistributionModels.pseudovoigt 0 ⭐ 139 😞 15 😞 56.25% 🙂 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py calculated_model 7 ⭐ 143 😞 9 🙂 58.84% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added the python Pull requests that update Python code label Feb 17, 2023
@Anselmoo Anselmoo self-assigned this Feb 18, 2023
@Anselmoo Anselmoo marked this pull request as ready for review February 18, 2023 15:17
@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance Maintenance & Security labels Feb 18, 2023
@codecov
Copy link

codecov bot commented Feb 18, 2023 •
edited
Loading

Codecov Report

Merging #611 (10e30e8) into main (d8d517d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 10e30e8 differs from pull request most recent head c9ca0fc. Consider uploading reports for the commit c9ca0fc to get more accurate results

@@            Coverage Diff            @@
##              main      #611   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         3553      3499   -54     
=========================================
- Hits          3553      3499   -54
Impacted Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/models.py 100.00% <100.00%> (ø)
spectrafit/test/test_models.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anselmoo
fix: 📝 Correct links
4ea249a 
Correct links in `mkdocs` to `code`
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 18, 2023
@Anselmoo Anselmoo added the enhancement New feature or request label Feb 19, 2023
josephzsombor
josephzsombor reviewed Feb 20, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo merged commit 1332983 into main Feb 20, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue610 branch February 20, 2023 18:42
Anselmoo added a commit that referenced this pull request Feb 20, 2023
@Anselmoo
fix: ✨ Add cumulative gaussian (#611)
e6d7291 
* fix: ✨ Add `cumulative gaussian`

* test: ♻️ Add and refactore `models` and `tests`

* fix: 🧪 Fixed wrong assert comparsion

* fix: 📝 Correct links

* Correct links in `mkdocs` to `code`

* fix: ⬆️ increase back coverage rate

* fix: ⚡ finished review
fix: ✨ Add `cumulative gaussian`

test: ♻️ Add and refactore `models` and `tests`

docs: 📝 Missing img
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephzsombor josephzsombor josephzsombor approved these changes

Assignees

@Anselmoo Anselmoo

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request maintenance Maintenance & Security python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: fitting with simultaneous normalization and background correction

2 participants

@Anselmoo @josephzsombor