Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ♻️ Rewrite notation for cumulative functions #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: ♻️ Rewrite notation for cumulative functions #633

merged 3 commits into from
Mar 2, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Mar 2, 2023 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed: [Bug]: Model Check #632
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@Anselmoo Anselmoo requested a review from josephzsombor March 2, 2023 06:28
@github-actions github-actions bot added the python Pull requests that update Python code label Mar 2, 2023
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 2, 2023 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 1.93 ⭐ 1.90 ⭐ -0.03 👍
Method Length 74.63 🙂 74.47 🙂 -0.16 👍
Working memory 6.08 ⭐ 6.12 ⭐ 0.04 👎
Quality 78.67% ⭐ 78.64% ⭐ -0.03% 👎
Other metrics Before After Change
Lines 2229 2294 65
Changed files Quality Before Quality After Quality Change
spectrafit/models.py 74.15% 🙂 74.26% 🙂 0.11% 👍
spectrafit/test/test_models.py 83.78% ⭐ 83.75% ⭐ -0.03% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/models.py ModelParameters.define_parameters_auto 15 🙂 650 ⛔ 10 😞 35.78% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/test/test_models.py TestModelParametersSolver.test_all_model_local 0 ⭐ 522 ⛔ 8 🙂 54.40% 🙂 Try splitting into smaller methods
spectrafit/test/test_models.py TestModelParametersSolver.test_all_model_global 0 ⭐ 521 ⛔ 8 🙂 54.40% 🙂 Try splitting into smaller methods
spectrafit/models.py DistributionModels.pseudovoigt 0 ⭐ 139 😞 15 😞 56.25% 🙂 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py calculated_model 7 ⭐ 143 😞 9 🙂 58.84% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #633 (f2e1863) into main (45c2451) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f2e1863 differs from pull request most recent head 722bc05. Consider uploading reports for the commit 722bc05 to get more accurate results

@@            Coverage Diff            @@
##              main      #633   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         3500      3507    +7     
=========================================
+ Hits          3500      3507    +7
Impacted Files Coverage Δ
spectrafit/test/test_models.py 100.00% <ø> (ø)
spectrafit/models.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo merged commit 90585bf into main Mar 2, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue632 branch March 2, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephzsombor josephzsombor Awaiting requested review from josephzsombor

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Model Check

1 participant

@Anselmoo