Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: ⚡ Using the distribution API #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

feat: ⚡ Using the distribution API #644

merged 1 commit into from
Mar 5, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Mar 5, 2023 •
edited
Loading

Fixes #603

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 5, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.94%.

Quality metrics Before After Change
Complexity 2.35 ⭐ 2.17 ⭐ -0.18 👍
Method Length 80.98 🙂 83.19 🙂 2.21 👎
Working memory 11.24 😞 14.90 😞 3.66 👎
Quality 62.29% 🙂 59.35% 🙂 -2.94% 👎
Other metrics Before After Change
Lines 1601 1655 54
Changed files Quality Before Quality After Quality Change
spectrafit/__init__.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/models.py 74.19% 🙂 74.19% 🙂 0.00%
spectrafit/api/models_model.py 37.47% 😞 34.54% 😞 -2.93% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/models.py ModelParameters.define_parameters_auto 15 🙂 650 ⛔ 10 😞 35.78% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py DistributionModels.pseudovoigt 0 ⭐ 139 😞 15 😞 56.25% 🙂 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py calculated_model 7 ⭐ 143 😞 9 🙂 58.84% 🙂 Try splitting into smaller methods
spectrafit/models.py AutoPeakDetection.initialize_peak_detection 3 ⭐ 213 ⛔ 4 ⭐ 68.75% 🙂 Try splitting into smaller methods
spectrafit/models.py DistributionModels.cvoigt 0 ⭐ 66 🙂 10 😞 73.97% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance Maintenance & Security python Pull requests that update Python code labels Mar 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo added enhancement New feature or request codespaces Everything connected to GitHub's Codespaces labels Mar 5, 2023
@codecov
Copy link

codecov bot commented Mar 5, 2023 •
edited
Loading

Codecov Report

Merging #644 (80b72d5) into main (6c550a1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #644   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         3520      3550   +30     
=========================================
+ Hits          3520      3550   +30
Impacted Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/api/models_model.py 100.00% <100.00%> (ø)
spectrafit/models.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anselmoo Anselmoo merged commit 183e095 into main Mar 5, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue603 branch March 5, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codespaces Everything connected to GitHub's Codespaces dependencies Pull requests that update a dependency file enhancement New feature or request maintenance Maintenance & Security python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Codespaces-Feature]: DistributionModelAPI for model check [Docs]: Using builtin release drafter

1 participant

@Anselmoo