Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: 🐛 Support of bool and {} for confidence #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 22, 2023
Merged

fix: 🐛 Support of bool and {} for confidence #705

merged 8 commits into from
Mar 22, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Mar 20, 2023 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed: Should be both bool or dict #704
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance Maintenance & Security release Release labels Mar 20, 2023
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 20, 2023 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.24%.

Quality metrics Before After Change
Complexity 0.92 ⭐ 0.93 ⭐ 0.01 👎
Method Length 60.34 ⭐ 60.50 ⭐ 0.16 👎
Working memory 8.23 🙂 8.16 🙂 -0.07 👍
Quality 76.32% ⭐ 76.56% ⭐ 0.24% 👍
Other metrics Before After Change
Lines 1721 1764 43
Changed files Quality Before Quality After Quality Change
spectrafit/__init__.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/api/report_model.py 39.97% 😞 39.97% 😞 0.00%
spectrafit/plugins/notebook.py 75.38% ⭐ 75.36% ⭐ -0.02% 👎
spectrafit/plugins/test/test_notebook.py 85.84% ⭐ 86.03% ⭐ 0.19% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/plugins/notebook.py SpectraFitNotebook.__init__ 3 ⭐ 358 ⛔ 43 ⛔ 32.44% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/plugins/notebook.py SpectraFitNotebook.solver_model 8 ⭐ 180 😞 14 😞 45.57% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/plugins/notebook.py DataFramePlot.plot_2dataframes 6 ⭐ 424 ⛔ 8 🙂 49.11% 😞 Try splitting into smaller methods
spectrafit/plugins/notebook.py DataFramePlot.plot_metric 0 ⭐ 195 😞 8 🙂 63.06% 🙂 Try splitting into smaller methods
spectrafit/plugins/notebook.py ExportReport.__init__ 0 ⭐ 90 🙂 11 😞 68.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Anselmoo Anselmoo enabled auto-merge March 20, 2023 20:48
@Anselmoo Anselmoo added testing Improve testing & coverage python Pull requests that update Python code labels Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023 •
edited
Loading

Codecov Report

Merging #705 (91af2cd) into main (b43d3d9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #705   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         3570      3583   +13     
=========================================
+ Hits          3570      3583   +13
Impacted Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/api/report_model.py 100.00% <100.00%> (ø)
spectrafit/plugins/notebook.py 100.00% <100.00%> (ø)
spectrafit/plugins/test/test_notebook.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot removed testing Improve testing & coverage python Pull requests that update Python code labels Mar 20, 2023
@Anselmoo Anselmoo added testing Improve testing & coverage python Pull requests that update Python code labels Mar 20, 2023
@Anselmoo Anselmoo disabled auto-merge March 20, 2023 21:08
@Anselmoo Anselmoo enabled auto-merge (squash) March 20, 2023 21:08
@github-actions github-actions bot removed testing Improve testing & coverage python Pull requests that update Python code labels Mar 22, 2023
@Anselmoo Anselmoo disabled auto-merge March 22, 2023 06:21
@Anselmoo Anselmoo enabled auto-merge (squash) March 22, 2023 06:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo merged commit 3556b18 into main Mar 22, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue704 branch March 22, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file maintenance Maintenance & Security release Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should be both bool or dict

1 participant

@Anselmoo