Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Update weekly-poetry-bot.yml #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2024
Merged

fix: Update weekly-poetry-bot.yml #1485

merged 1 commit into from
Aug 11, 2024

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Aug 11, 2024 •
edited by sourcery-ai bot
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Update the schedule for the weekly-poetry-bot.yml CI workflow to run every hour instead of every day for testing.

CI:

  • Update the schedule for the weekly-poetry-bot workflow to run every hour for testing purposes.

@semanticdiff-com
Copy link

Review changes with SemanticDiff.

@Anselmoo Anselmoo enabled auto-merge August 11, 2024 10:09
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 11, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the schedule for the weekly-poetry-bot workflow to run every hour for testing purposes. The change is implemented by modifying the cron expression in the YAML configuration file.

File-Level Changes

Files Changes
.github/workflows/weekly-poetry-bot.yml Modified the cron schedule to run the workflow every hour instead of every day.
Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added the github-actions Pull requests that update Github_actions code label Aug 11, 2024
sourcery-ai[bot]
sourcery-ai bot reviewed Aug 11, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider reducing the frequency of the cron job for testing (e.g., every 6 or 12 hours instead of every hour) to avoid potential rate limiting issues.
  • Add a comment in the workflow file explaining the reason for the more frequent schedule and how long it's expected to remain in place.
  • Keep both the original weekly schedule and the new testing schedule in the file (with one commented out) for easier switching between production and testing configurations.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Aug 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4c24c81) to head (e9ded80).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1485   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4467           
=========================================
  Hits          4467      4467
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Anselmoo Anselmoo merged commit 26ad60e into main Aug 11, 2024
@Anselmoo Anselmoo deleted the Anselmoo-patch-1 branch August 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

github-actions Pull requests that update Github_actions code size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Anselmoo