Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(deps): ⬆️ update dependency pylint to v3 #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2024
Merged

chore(deps): ⬆️ update dependency pylint to v3 #1502

merged 2 commits into from
Aug 21, 2024

Conversation

@Anselmoo
Copy link
Owner

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@Anselmoo Anselmoo enabled auto-merge August 21, 2024 04:43
@semanticdiff-com
Copy link

semanticdiff-com bot commented Aug 21, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 3 files.

Filename Status
❔ poetry.lock Unsupported file format
❔ pyproject.toml Unsupported file format
✔️ spectrafit/plugins/test/test_converter.py Analyzed

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 21, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@github-actions github-actions bot added maintenance Maintenance & Security dependencies Pull requests that update a dependency file root labels Aug 21, 2024
@github-actions github-actions bot added testing Improve testing & coverage python Pull requests that update Python code labels Aug 21, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c17e072) to head (30fb3a5).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1502   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4467      4466    -1     
=========================================
- Hits          4467      4466    -1
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
spectrafit/plugins/test/test_converter.py 100.00% <100.00%> (ø)

@Anselmoo Anselmoo merged commit 8e45af8 into main Aug 21, 2024
@Anselmoo Anselmoo deleted the Anselmoo/issue1498 branch August 21, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file maintenance Maintenance & Security python Pull requests that update Python code root size/S testing Improve testing & coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore(deps): update dependency pylint to v3

1 participant

@Anselmoo