Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build: 🔒 Warning for the end of support for Python 3.8 is approaching #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

build: 🔒 Warning for the end of support for Python 3.8 is approaching #1608

merged 1 commit into from
Sep 24, 2024

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Sep 24, 2024 •
edited by sourcery-ai bot
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Introduce a warning for users about the upcoming end-of-life for Python 3.8 support in SpectraFit, and update the documentation to reflect this change.

New Features:

  • Add a warning message for users running SpectraFit on Python 3.8, indicating that support for this version is approaching its end-of-life.

Documentation:

  • Update documentation to include a warning about the upcoming deprecation of Python 3.8 support, encouraging users to upgrade to Python 3.9 or newer.

@Anselmoo Anselmoo enabled auto-merge September 24, 2024 10:05
@semanticdiff-com
Copy link

semanticdiff-com bot commented Sep 24, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Filename Status
✔️ spectrafit/__init__.py Analyzed

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 24, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds a warning message for the upcoming end of support for Python 3.8 in the SpectraFit project. It modifies the __init__.py file to include a version check and display a deprecation warning for users running Python 3.8.

File-Level Changes

Change Details Files
Add deprecation warning for Python 3.8
  • Import sys and warnings modules
  • Add version check for Python 3.8
  • Display DeprecationWarning for Python 3.8 users
  • Include link to Python end-of-life branches documentation
 spectrafit/__init__.py
Update project documentation
  • Add warning about Python version support in the docstring
  • Mention upcoming deprecation of Python 3.8 support
  • Include link to Python release schedule
 spectrafit/__init__.py

Sequence Diagram

No sequence diagram generated.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added python Pull requests that update Python code release Release labels Sep 24, 2024
sourcery-ai[bot]
sourcery-ai bot reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88280d0) to head (f156f42).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1608   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         4464      4468    +4     
=========================================
+ Hits          4464      4468    +4
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)

@Anselmoo Anselmoo merged commit 3d0106d into main Sep 24, 2024
32 checks passed
@Anselmoo Anselmoo deleted the Anselmoo/issue1607 branch September 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

python Pull requests that update Python code release Release size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning for the end of support for Python 3.8 is approaching

1 participant

@Anselmoo