Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: 🧪 remove unnecessary type ignore for AutoPeakDetection instantiation #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2025
Merged

fix: 🧪 remove unnecessary type ignore for AutoPeakDetection instantiation #1818

merged 3 commits into from
Feb 9, 2025

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Feb 9, 2025 •
edited by sourcery-ai bot
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Bug Fixes:

  • Removed an unnecessary type ignore comment in the AutoPeakDetection instantiation within the test suite.

@Anselmoo Anselmoo enabled auto-merge February 9, 2025 07:50
@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 9, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  spectrafit/test/test_models.py  13% smaller
  .pre-commit-config.yaml  0% smaller
  uv.lock Unsupported file format

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 9, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This PR removes the unnecessary 'type: ignore' directive from the AutoPeakDetection instantiation in the test file, ensuring proper type checking and maintaining code clarity.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the unnecessary type ignore comment from AutoPeakDetection instantiation.
  • Deleted the type ignore directive in the instantiation of AutoPeakDetection in the test.
  • Ensured that the test functionality remains intact while promoting better type safety.
 spectrafit/test/test_models.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added testing Improve testing & coverage python Pull requests that update Python code labels Feb 9, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Feb 9, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pull-request-size pull-request-size bot added size/L and removed size/XS labels Feb 9, 2025
@github-actions github-actions bot added maintenance Maintenance & Security dependencies Pull requests that update a dependency file pre-commit root labels Feb 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Anselmoo Anselmoo disabled auto-merge February 9, 2025 07:56
@Anselmoo Anselmoo merged commit babf4df into main Feb 9, 2025
35 checks passed
@Anselmoo Anselmoo deleted the fix-type-hints branch February 9, 2025 07:57
@codecov
Copy link

codecov bot commented Feb 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f3e8af) to head (70775a7).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1818   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         4535      4535           
=========================================
  Hits          4535      4535
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
spectrafit/test/test_models.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file maintenance Maintenance & Security pre-commit python Pull requests that update Python code root size/L testing Improve testing & coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Anselmoo