Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Working with Athena #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2022
Merged

Working with Athena #340

merged 3 commits into from
Jun 26, 2022

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jun 26, 2022 •
edited
Loading

All PR-Submissions:

Fixed: #324
Fixed: #331

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission?

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@Anselmoo Anselmoo added the enhancement New feature or request label Jun 26, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 26, 2022 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.22%.

Quality metrics Before After Change
Complexity 4.97 ⭐ 4.95 ⭐ -0.02 👍
Method Length 61.00 ⭐ 61.69 🙂 0.69 👎
Working memory 6.12 ⭐ 6.16 ⭐ 0.04 👎
Quality 73.97% 🙂 73.75% 🙂 -0.22% 👎
Other metrics Before After Change
Lines 801 810 9
Changed files Quality Before Quality After Quality Change
spectrafit/init.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/spectrafit.py 64.51% 🙂 64.35% 🙂 -0.16% 👎
spectrafit/tools.py 79.83% ⭐ 79.64% ⭐ -0.19% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/spectrafit.py extracted_from_command_line_runner 18 🙂 224 ⛔ 6 ⭐ 49.40% 😞 Try splitting into smaller methods
spectrafit/spectrafit.py get_args 0 ⭐ 255 ⛔ 6 ⭐ 64.11% 🙂 Try splitting into smaller methods
spectrafit/tools.py PostProcessing.make_residual_fit 4 ⭐ 99 🙂 10 😞 65.16% 🙂 Extract out complex expressions
spectrafit/tools.py load_data 2 ⭐ 86 🙂 10 😞 68.98% 🙂 Extract out complex expressions
spectrafit/tools.py PostProcessing.rename_columns 3 ⭐ 51 ⭐ 11 😞 71.44% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Anselmoo Anselmoo added the documentation Improvements or additions to documentation label Jun 26, 2022
@codecov
Copy link

codecov bot commented Jun 26, 2022 •
edited
Loading

Codecov Report

Merging #340 (23567aa) into main (65f0db7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 23567aa differs from pull request most recent head c565767. Consider uploading reports for the commit c565767 to get more accurate results

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   98.55%   98.55%   +0.01%     
==========================================
  Files          10       10              
  Lines        1239     1240       +1     
==========================================
+ Hits         1221     1222       +1     
  Misses         18       18
Impacted Files Coverage Δ
spectrafit/tools.py 98.11% <ø> (ø)
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/spectrafit.py 96.94% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f0db7...c565767. Read the comment docs.

@Anselmoo Anselmoo merged commit 5ff394a into main Jun 26, 2022
@Anselmoo Anselmoo deleted the develop branch June 26, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs]: Extending the Examples in the docs [Feature]: Default support for data.nor files processed with Athena

1 participant

@Anselmoo