Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: 🚧 Adding input / output converter #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2022
Merged

feat: 🚧 Adding input / output converter #347

merged 6 commits into from
Jun 26, 2022

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jun 26, 2022 •
edited
Loading

Input and ouput files can be now converted between json, yaml, and toml

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@Anselmoo
feat: 🚧 Adding input / output converter
f5b0afd 
Input and ouput files can be now converted between json, yaml, and toml

Fixed #337
@Anselmoo Anselmoo added documentation Improvements or additions to documentation enhancement New feature or request maintenance Maintenance & Security labels Jun 26, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 26, 2022 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.20%.

Quality metrics Before After Change
Complexity 2.36 ⭐ 2.36 ⭐ 0.00
Method Length 48.61 ⭐ 48.70 ⭐ 0.09 👎
Working memory 6.72 🙂 6.81 🙂 0.09 👎
Quality 79.64% ⭐ 79.44% ⭐ -0.20% 👎
Other metrics Before After Change
Lines 518 520 2
Changed files Quality Before Quality After Quality Change
spectrafit/tools.py 79.64% ⭐ 79.44% ⭐ -0.20% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/tools.py PostProcessing.make_residual_fit 4 ⭐ 99 🙂 10 😞 65.16% 🙂 Extract out complex expressions
spectrafit/tools.py read_input_file 4 ⭐ 76 🙂 10 😞 68.47% 🙂 Extract out complex expressions
spectrafit/tools.py load_data 2 ⭐ 82 🙂 10 😞 69.56% 🙂 Extract out complex expressions
spectrafit/tools.py PostProcessing.rename_columns 3 ⭐ 51 ⭐ 11 😞 71.44% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jun 26, 2022 •
edited
Loading

Codecov Report

Merging #347 (ffb8cf9) into main (2cded46) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   98.55%   98.64%   +0.10%     
==========================================
  Files          10       12       +2     
  Lines        1240     1323      +83     
==========================================
+ Hits         1222     1305      +83     
  Misses         18       18
Impacted Files Coverage Δ
spectrafit/plugins/converter.py 100.00% <100.00%> (ø)
spectrafit/plugins/test/test_converter.py 100.00% <100.00%> (ø)
spectrafit/tools.py 98.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cded46...ffb8cf9. Read the comment docs.

@Anselmoo
fix: ✨ converter
f58a51e 
fix: 🐛 Add PurePath Class to arg of input

fix: 🐛 Bump default type from str to Path

fix: 🎨 Turn back to str for spectrafit input

fix: 🎨 Increase coverage, fix defintion bug in choices
@Anselmoo Anselmoo merged commit d4dc46f into main Jun 26, 2022
@Anselmoo Anselmoo deleted the develop branch June 26, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request maintenance Maintenance & Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Input Convert as cmd tool

1 participant

@Anselmoo