feat: dataset label cleanup #9959
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| message: "Failed to save label changes. Please try again.", | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Bug: Label Sync Issue During Rapid User Actions
The auto-apply label logic has a race condition where rapid user selections can be lost. The useEffect hook, intended to sync local state, can overwrite recent user changes with stale server data when mutations are in flight. This results in labels appearing deselected unexpectedly and can cause incorrect or duplicate mutations.
Additional Locations (1)
| connections={connections} | ||
| datasetId={datasetId} | ||
| onCompleted={() => { | ||
| // Only close the create modal, keep the labels popover open |
There was a problem hiding this comment.
| // Only close the create modal, keep the labels popover open |
Let's nix the comment.
| */ | ||
| connections?: string[]; | ||
| /** | ||
| * Optional dataset ID to auto-apply the label to after creation |
There was a problem hiding this comment.
| * Optional dataset ID to auto-apply the label to after creation | |
| * Optional dataset ID. If provided, newly created labels will be auto-applied to the dataset upon creation. |
| const selectedLabelIds = useMemo( | ||
| () => datasetData?.labels?.map((label) => label.id) || [], | ||
| [datasetData?.labels] | ||
| ); | ||
| const [search, setSearch] = useState(""); | ||
| const [selected, setSelected] = useState<Selection>( | ||
| () => new Set(selectedLabelIds) | ||
| ); | ||
| const [hasChanges, setHasChanges] = useState(false); | ||
|
|
||
| // Sync local selection state when dataset labels change (e.g., from auto-apply) | ||
| useEffect(() => { | ||
| setSelected(new Set(selectedLabelIds)); | ||
| }, [selectedLabelIds]); |
There was a problem hiding this comment.
We want to rely on Relay for the re-rendering of the labels rather than a useEffect hook.
| setSelected(selection); | ||
|
|
||
| // Check if there are changes from the original selection | ||
| // Auto-apply changes immediately |
There was a problem hiding this comment.
| // Auto-apply changes immediately |
| message: "Failed to save label changes. Please try again.", | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
What made this change necessary?
| onCompleted, | ||
| onCompleted: (response) => { | ||
| // Auto-apply the new label to the dataset if datasetId is provided | ||
| if (datasetId && response.createDatasetLabel?.datasetLabel?.id) { |
There was a problem hiding this comment.
| if (datasetId && response.createDatasetLabel?.datasetLabel?.id) { | |
| if (datasetId && response.createDatasetLabel.datasetLabel.id) { |
| // Still call onCompleted even if auto-apply fails | ||
| // The label was created successfully | ||
| onCompleted(); |
There was a problem hiding this comment.
We need to notify on error here.
Note
Streamlines dataset label UX by auto-applying selections and newly created labels, removing the save flow, and simplifying menu interactions and form UI.
DatasetLabelConfigButton; removed explicit Save flow andonCloseprop; popover stays open when creating labels; selection syncs with dataset viauseEffect/useMemo.NewDatasetLabelDialogaccepts optionaldatasetIdand auto-applies the newly created label viaNewDatasetLabelDialogSetLabelsMutation(generated file added); connections still updated.DatasetActionMenuopens label configuration directly from the menu (no submenu/chevron); addsDialogTriggerwith invisible anchor to position popover.NewLabelFormUI cleanup: removes helper descriptions, tweaks placeholders and layout.Edit Labelslink only (removed Manage/Save).Written by Cursor Bugbot for commit 5ce6bb9. This will update automatically on new commits. Configure here.