Conversation
oysheng
reviewed
May 23, 2020
| // define requestedAmount: Integer = valueAmount * ratioNumerator / ratioDenominator | ||
| // define requestedAmount: Integer = requestedAmount * 999 / 1000 | ||
| // verify requestedAmount > 0 | ||
| // verify requestedAmount >= 0 |
Contributor
There was a problem hiding this comment.
这个地方会有点危险，等于0就表示用户什么都没支付就能解锁合约的钱了，就算收取了手续费也是没有合约验证的。并且支持等于0就表示支持ouput等于0了，validate估计也过不了。建议在撮合层做一下限制和判断
oysheng
approved these changes
May 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.