-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CMake - rebase + travis-ci integration #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Probably you need to rebase. I see too many commits ahead of yours. |
|
Not necessarily. This is a rebase onto dev, so it's bound to have a whole lot of different commits than BVLC/cmake. |
|
CMake cannot find CUDA_curand lib (CUDA runtime lib is being found all right) while building on Travis-CI machines. I've reinstalled CUDA locally with commands from .travis.yml and eveything works fine. Any idea how to approach this problem apart from mailing guys from Travis-CI? |
|
curand support was added in Cmake 2.8.8-rc1 with this commit Kitware/CMake@154f537 |
|
It is ok to rebase this from dev but i see commit starting from May 26, 2014. |
|
Hi @akosiorek: you probably want to look at PR #561 -- @shelhamer added a CPU_ONLY flag to support building without CUDA at all. That PR added edit: "we added" -> "@shelhamer added", didn't meant to steal the credit :) |
|
@jeffdonahue I've managed CUDA_curand so it compiles fine now - I added a line in |
|
Great, thanks for the update! I assume your changes to .travis.yml are work in progress, but just a note: the build will still need to succeed fully without cmake (at least in the short term), so we can't remove/comment out the existing build in .travis.yml (but maybe you did that temporarily just to be able to check faster whether the cmake build succeeds, which is perfectly reasonable). Please let me know when this is ready for review. |
|
Hey @akosiorek @jeffdonahue , just got your email (sorry for the long delay) I'm glad you’re adding cmake builds. It will be a nice addition to caffe. Not sure if it would be helpful to y'all, but when I was debugging the travis.yml setup, I was extensively using docker to test the reproducibility of the build. Have you guys used docker much before? Here's the Dockerfile used to generate an ubuntu 12.04 machine that is capable of running caffe: https://gist.github.com/huyng/7fd5bdacaee5ba0e350f If you put that in a directory and run
you should be able to verify that all the prereqs for caffe build correctly. Alternatively, you can run your tests inside a pre-packaged docker Image file that I've built from the above Dockerfile by running:
-H |
|
@huyng thanks, docker should make testing a whole lot easier. There's a little problem, though. I've got connection timeouts to docker repos. These are due to a proxy we're using here. I'm leaving the company in a week and I won't be able to get a security exception. I'll try to handle it from home. Meanwhile I've to count on Travis builds. |
|
@akosiorek Are you having this kind of problem with docker? moby/moby#402 |
|
@bhack I do. I've seen this issue before but it doesn't work for me, nor any other I've managed to google, sadly. The good news is that Snappy and with it the whole CMake build works now. Should I work on CPU_ONLY build in this PR or start a new one? |
|
@akosiorek Good! Is it ready to try a Travis build? If you resolve with rabase and this automerge then i think Travis will start. |
|
@akosiorek I see it is passed on you fork. But what i don't understand it is why there are commits starting from 26 May. I remember that Cmake branch was fresher. |
|
@bhack I know, but I just run where |
|
@jeffdonahue it seems to be ready but @bhack has some concerns. Could you have a look at it? How about CPU_ONLY build? I've got it working now. Do you want it as a part of this PR? |
|
@akosiorek Have you started your development rebasing BVLC:cmake on BVLC:dev? |
|
@bhack Just as I told you, this very PR is rebased on BVLC:dev. I know that some commits look old, but I can't help it. |
|
Thanks @akosiorek, I've force pushed this to BVLC cmake. I removed a bunch of unnecessary changes to the tests in your "fixed lint issues" commit. |
Rebased to BVLC/dev as asked by @jeffdonahue in #623. Working on CMake build to travis-ci integration.
It will contain merge conflicts due to a rebase. If this PR is considered successful it should be forced pushed onto BVLC/cmake