Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@akosiorek
Copy link
Contributor

Rebased to BVLC/dev as asked by @jeffdonahue in #623. Working on CMake build to travis-ci integration.

It will contain merge conflicts due to a rebase. If this PR is considered successful it should be forced pushed onto BVLC/cmake

@bhack
Copy link
Contributor

bhack commented Jul 23, 2014

Probably you need to rebase. I see too many commits ahead of yours.

@akosiorek
Copy link
Contributor Author

Not necessarily. This is a rebase onto dev, so it's bound to have a whole lot of different commits than BVLC/cmake.

@akosiorek
Copy link
Contributor Author

CMake cannot find CUDA_curand lib (CUDA runtime lib is being found all right) while building on Travis-CI machines. I've reinstalled CUDA locally with commands from .travis.yml and eveything works fine. Any idea how to approach this problem apart from mailing guys from Travis-CI?

@bhack
Copy link
Contributor

bhack commented Jul 23, 2014

curand support was added in Cmake 2.8.8-rc1 with this commit Kitware/CMake@154f537

@bhack
Copy link
Contributor

bhack commented Jul 23, 2014

It is ok to rebase this from dev but i see commit starting from May 26, 2014.

@jeffdonahue
Copy link
Contributor

Hi @akosiorek: you probably want to look at PR #561 -- @shelhamer added a CPU_ONLY flag to support building without CUDA at all. That PR added #ifndef CPU_ONLY guards around parts of the code that call into CUDA functionality, so if you've added any new CUDA functionality you may need to add similar guards in order to compile properly. You can test that compilation works without waiting for Travis -- you just have to do export CPU_ONLY=1 before compiling (and make sure to do make clean and/or the CMake equivalent before recompiling in CPU_ONLY mode).

edit: "we added" -> "@shelhamer added", didn't meant to steal the credit :)

@akosiorek
Copy link
Contributor Author

@jeffdonahue I've managed CUDA_curand so it compiles fine now - I added a line in .travis.yml to install CMake 2.8.12 before building. Now I have some problems with snappy - CMake can't find it for some reason, I'll get to it tomorrow. Later I'll try to make CMake CPU only build.

@jeffdonahue
Copy link
Contributor

Great, thanks for the update! I assume your changes to .travis.yml are work in progress, but just a note: the build will still need to succeed fully without cmake (at least in the short term), so we can't remove/comment out the existing build in .travis.yml (but maybe you did that temporarily just to be able to check faster whether the cmake build succeeds, which is perfectly reasonable).

Please let me know when this is ready for review.

@huyng
Copy link
Contributor

huyng commented Jul 24, 2014

Hey @akosiorek @jeffdonahue , just got your email (sorry for the long delay)

I'm glad you’re adding cmake builds. It will be a nice addition to caffe. Not sure if it would be helpful to y'all, but when I was debugging the travis.yml setup, I was extensively using docker to test the reproducibility of the build.

Have you guys used docker much before?

Here's the Dockerfile used to generate an ubuntu 12.04 machine that is capable of running caffe:

https://gist.github.com/huyng/7fd5bdacaee5ba0e350f

If you put that in a directory and run

docker build

you should be able to verify that all the prereqs for caffe build correctly.

Alternatively, you can run your tests inside a pre-packaged docker Image file that I've built from the above Dockerfile by running:

docker run -t -i huyng/caffebase /bin/bash

-H

@akosiorek
Copy link
Contributor Author

@huyng thanks, docker should make testing a whole lot easier. There's a little problem, though. I've got connection timeouts to docker repos. These are due to a proxy we're using here. I'm leaving the company in a week and I won't be able to get a security exception. I'll try to handle it from home. Meanwhile I've to count on Travis builds.

@bhack
Copy link
Contributor

bhack commented Jul 24, 2014

@akosiorek Are you having this kind of problem with docker? moby/moby#402

@akosiorek
Copy link
Contributor Author

@bhack I do. I've seen this issue before but it doesn't work for me, nor any other I've managed to google, sadly.

The good news is that Snappy and with it the whole CMake build works now. Should I work on CPU_ONLY build in this PR or start a new one?

@bhack
Copy link
Contributor

bhack commented Jul 24, 2014

@akosiorek Good! Is it ready to try a Travis build? If you resolve with rabase and this automerge then i think Travis will start.

@akosiorek
Copy link
Contributor Author

@bhack It's passed a Travis build already, see here. Automerge will not be possible due to rebase, I'm afraid. That's how it works.

@bhack
Copy link
Contributor

bhack commented Jul 24, 2014

@akosiorek I see it is passed on you fork. But what i don't understand it is why there are commits starting from 26 May. I remember that Cmake branch was fresher.

@akosiorek
Copy link
Contributor Author

@bhack I know, but I just run

git remote update
git rebase bvlc/dev

where bvlc points to https://github.com/bvlc/caffe. Any idea how to fix it?

@akosiorek
Copy link
Contributor Author

@jeffdonahue it seems to be ready but @bhack has some concerns. Could you have a look at it? How about CPU_ONLY build? I've got it working now. Do you want it as a part of this PR?

@bhack
Copy link
Contributor

bhack commented Jul 24, 2014

@akosiorek Have you started your development rebasing BVLC:cmake on BVLC:dev?

@akosiorek
Copy link
Contributor Author

@bhack Just as I told you, this very PR is rebased on BVLC:dev. I know that some commits look old, but I can't help it.

@jeffdonahue
Copy link
Contributor

Thanks @akosiorek, I've force pushed this to BVLC cmake. I removed a bunch of unnecessary changes to the tests in your "fixed lint issues" commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants