Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set propagate_down=true to force backprop to a particular bottom #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2016
Merged

Set propagate_down=true to force backprop to a particular bottom #3942

merged 2 commits into from
Apr 5, 2016

Conversation

@jeffdonahue
Copy link
Contributor

Currently setting propagate_down=true has no effect -- only setting propagate_down=false has an effect (disabling backpropagation when it would otherwise be enabled). This PR changes the behavior of propagate_down=true -- if set, backpropagation is forced even if it's not needed, sort of like a per-bottom force_backward=true setting.

@jeffdonahue
Copy link
Contributor Author

It's hard to tell from the reordered history here on GitHub, but the add TestForcePropagateDown commit (dee01c8) is first and the test should fail since the behavior isn't implemented. The second commit (0f36571) is the one that actually updates the behavior and the tests should then pass.

@jeffdonahue
Copy link
Contributor Author

Hm, well, for some reason the tests here both passed, but on my repo's Travis, as expected, the first commit (dee01c8) failed and the second commit (0f36571) passed.

@shelhamer
Copy link
Member

Thanks Jeff, this looks good except that the proto comment for propagate_down should reflect that it now forces both cases whether propagating by true or skipping by false. Feel free to merge once that is included.

@jeffdonahue jeffdonahue force-pushed the propagate-down-true branch from 0f36571 to 77cde9c Compare April 5, 2016 17:03
@jeffdonahue
Copy link
Contributor Author

Thanks for the review Evan! Proto comment updated.

@jeffdonahue jeffdonahue merged commit 843575e into BVLC:master Apr 5, 2016
@jeffdonahue jeffdonahue deleted the propagate-down-true branch April 5, 2016 17:15
@ih4cku ih4cku mentioned this pull request Apr 13, 2016
Open
myfavouritekk added a commit to myfavouritekk/caffe that referenced this pull request Aug 15, 2016
@myfavouritekk
Set propagate_down=true to force backprop to a particular bottom (bor…
3461901 
…rowed from BVLC#3942).
fxbit pushed a commit to Yodigram/caffe that referenced this pull request Sep 1, 2016
@jeffdonahue @fxbit
Merge pull request BVLC#3942 from jeffdonahue/propagate-down-true
08cc2c4 
Set propagate_down=true to force backprop to a particular bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffdonahue @shelhamer