feat: add falcon-e and other bitnet support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaizzy
requested changes
Jun 10, 2025
Owner
Blaizzy
left a comment
There was a problem hiding this comment.
This is amazing, well done!
I just have one tiny nit
Owner
There was a problem hiding this comment.
Could we move this logic to the utils in quants folder? What do you think?
Owner
There was a problem hiding this comment.
Awesome, ping me when you ready :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title and discussion in ml-explore#219
This PR adds the support for other BitNet models and not limited to Falcon-E
Old Bitnet versions use inverted scales -> this is the main change in bitnet linear layer
@Blaizzy