fix:minor fixes #77
Merged
fix:minor fixes #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2d528f1 in 48 seconds
More details
- Looked at
713lines of code in8files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_I44q4GYPsFq00owH
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
| const originalRelation = role[SharedMetadata]?.inheritanceOrigin || value.name; | ||
|
|
||
| if ($things.length > 1) { |
There was a problem hiding this comment.
Changing from throw new Error to console.warn reduces the visibility of a critical schema configuration issue and may allow the application to operate in an unintended state. Consider reverting this change to ensure that such configuration errors are explicitly handled and not overlooked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Minor fixes and added failing test case for multi-nested mutations and deletions.
Key points:
0.10.24.0.10.24.console.warnfor unsupported multiple roles.nanoid.enrichfunction.parseFilter.Generated with ❤️ by ellipsis.dev