flake.nix (3)

71-76: Gate Linux-only GPU/QEMU deps to avoid eval failures on macOS.

qemu_kvm, mesa, vulkan-loader, and libglvnd are Linux-only. The emulator shell will fail to evaluate on aarch64-darwin/x86_64-darwin when enableEmulator = true. Guard these deps by host OS.

-              ++ pkgs.lib.optionals enableEmulator [
+              ++ pkgs.lib.optionals (enableEmulator && pkgs.stdenv.isLinux) [
                 libglvnd
                 mesa
                 vulkan-loader
                 qemu_kvm
               ];

Also mirror this guard in the default shell:

-              ++ pkgs.lib.optionals enableEmulator [ # This list will be empty as enableEmulator is false
+              ++ pkgs.lib.optionals (enableEmulator && pkgs.stdenv.isLinux) [ # Linux-only
                 libglvnd
                 mesa
                 vulkan-loader
                 qemu_kvm
               ];

---

26-27: Select emulator ABI dynamically by host arch (x86_64 vs arm64).

Hard-coding x86_64 breaks Apple Silicon and aarch64 Linux. Pick ABI at eval/run time and use it for both SDK composition and AVD creation.

-          abiVersions = [ "x86_64" ];
+          abiVersions = [ (if pkgs.stdenv.isAarch64 then "arm64-v8a" else "x86_64") ];

And in shellHook, choose the system image accordingly:

-                if ! "$ANDROID_HOME/cmdline-tools/latest/bin/avdmanager" list avd | grep -q "ReactNative_API35"; then
+                ARCH="$(uname -m)"
+                if [ "$ARCH" = "arm64" ] || [ "$ARCH" = "aarch64" ]; then
+                  AVD_ABI="arm64-v8a"
+                else
+                  AVD_ABI="x86_64"
+                fi
+                if ! "$ANDROID_HOME/cmdline-tools/latest/bin/avdmanager" list avd | grep -q "ReactNative_API35"; then
                   echo "Creating default AVD (ReactNative_API35 - Pixel 8 profile)..."
-                  echo "no" | "$ANDROID_HOME/cmdline-tools/latest/bin/avdmanager" create avd -n "ReactNative_API35" -k "system-images;android-35;google_apis;x86_64" -d "pixel_8"
+                  echo "no" | "$ANDROID_HOME/cmdline-tools/latest/bin/avdmanager" create avd -n "ReactNative_API35" -k "system-images;android-35;google_apis;$AVD_ABI" -d "pixel_8"
                   echo "AVD created. First launch may take longer."
                 fi

Also applies to: 32-35, 98-103

---

92-93: Use side-by-side NDK path; ndk-bundle is deprecated.

You already install specific NDK versions. Point env vars to the actual side-by-side dir to avoid broken toolchains.

-                export ANDROID_NDK_HOME="$ANDROID_HOME/ndk-bundle"
-                export NDK_HOME="$ANDROID_NDK_HOME"
+                if [ -d "$ANDROID_HOME/ndk" ]; then
+                  export ANDROID_NDK_HOME="$(ls -d "$ANDROID_HOME/ndk/"*/ 2>/dev/null | head -n1 | sed 's:/*$::')"
+                fi
+                export NDK_HOME="$ANDROID_NDK_HOME"

Apply the same change in the default shell’s shellHook.

Also applies to: 161-162

src/screens/browse/components/AvailableTab.tsx (2)

137-145: Avoid in-place mutation of filteredAvailablePlugins

Sorting mutates res (aliasing filteredAvailablePlugins). Clone before sort to prevent subtle state bugs.

-    return res
-      .sort((a, b) => a.lang.localeCompare(b.lang))
+    return [...res]
+      .sort((a, b) => a.lang.localeCompare(b.lang))
       .map((plg, i) => {
         return {
           ...plg,
           header: i === 0 ? true : plg.lang !== res[i - 1].lang,
         };
       });

---

129-134: Make ID search case-insensitive

plg.id isn’t lowercased; mixed-case IDs won’t match.

-          plg.name.toLocaleLowerCase().includes(lowerCaseSearchText) ||
-          plg.id.includes(lowerCaseSearchText),
+          plg.name.toLocaleLowerCase().includes(lowerCaseSearchText) ||
+          plg.id.toLocaleLowerCase().includes(lowerCaseSearchText),

android/app/src/main/assets/js/core.js (1)

145-152: Bug: implicit global variable ele

ele is assigned without declaration, creating a global and risking leaks/clobbering.

-  this.readable = element => {
-    ele = element ?? this.currentElement;
+  this.readable = element => {
+    const ele = element ?? this.currentElement;

src/screens/reader/components/SkeletonLines.tsx (1)

58-66: Width calculation bug with percentage strings

Number(width) for '90%' yields NaN, later producing NaN%. Compute percentages explicitly.

-    const skeletonWidth: number = width
-      ? Number(width)
-      : percentToNumberH('90%');
+    const skeletonWidth: number =
+      typeof width === 'string'
+        ? percentToNumberH(width)
+        : typeof width === 'number'
+        ? width
+        : percentToNumberH('90%');
...
-          width={
-            typeof width === 'string'
-              ? percentToNumberH(skeletonWidth) * randomNumber + '%'
-              : randomNumber * skeletonWidth
-          }
+          width={
+            typeof width === 'string'
+              ? percentToNumberH(width) * randomNumber
+              : randomNumber * skeletonWidth
+          }

Also applies to: 79-85

src/screens/reader/components/WebViewReader.tsx (1)

68-76: Change injected path to reader.readerSettings (critical mismatch)

core.js reads this.readerSettings.val; injecting to reader.settings.val will not update the value core uses.

Location: src/screens/reader/components/WebViewReader.tsx (lines 68–76). core references: android/app/src/main/assets/js/core.js (lines 58, 360, 393).

-          webViewRef.current?.injectJavaScript(
-            `reader.settings.val = ${MMKVStorage.getString(
+          webViewRef.current?.injectJavaScript(
+            `reader.readerSettings.val = ${MMKVStorage.getString(
               CHAPTER_READER_SETTINGS,
             )}`,
           );

src/screens/browse/loadingAnimation/SourceScreenSkeletonLoading.tsx (1)

21-31: SettingsContextProvider confirmed — add a defensive fallback for novelsPerRow.

SettingsContextProvider is present in src/navigators/Main.tsx (wraps navigation). Still guard numColumns in src/screens/browse/loadingAnimation/SourceScreenSkeletonLoading.tsx against 0/NaN to avoid runtime errors.

-  const numColumns = useMemo(
-    () => (orientation === 'landscape' ? 6 : novelsPerRow),
-    [orientation, novelsPerRow],
-  );
+  const numColumns = useMemo(() => {
+    const base = orientation === 'landscape' ? 6 : novelsPerRow;
+    return Math.max(1, Number.isFinite(base) ? base : 1);
+  }, [orientation, novelsPerRow]);

src/screens/settings/dynamic/modals/VoicePickerModal.tsx (1)

79-79: Ensure unique keys for voices without identifier

Multiple undefined identifiers will collide on 'system'.

Apply:

-          keyExtractor={item => item.identifier || 'system'}
+          keyExtractor={(item, index) =>
+            item.identifier || `${item.name}-${item.language}-${index}`
+          }

src/screens/GlobalSearchScreen/components/GlobalSearchResultsList.tsx (1)

107-114: Bug: extraData={inActivity.length} is always undefined.
inActivity is a Record; it has no length. FlatList won't re-render reliably.

Fix:

-              extraData={inActivity.length}
+              extraData={inActivity}

Alternatively: Object.keys(inActivity).length.

src/screens/settings/SettingsRepositoryScreen/SettingsRepositoryScreen.tsx (1)

58-58: User-facing typo: “respository”.
Fix the toast string.

-        showToast('A respository with this url already exists!');
+        showToast('A repository with this URL already exists!');

src/screens/reader/components/ReaderBottomSheet/ReaderValueChange.tsx (1)

58-60: Fix percent display and rounding (currently shows 1.7% instead of 170% and ignores decimals).

• When unit is '%', the value should be multiplied by 100.
• Pre-rounding with "*10/10" always assumes 1 decimal and double-rounds.

Apply:

-          {`${((settings[valueKey] * 10) / 10).toFixed(decimals)}${unit}`}
+          {`${formatValue(settings[valueKey], unit, decimals)}`}

Add inside component scope:

const formatValue = (val: number, unit?: string, decimals = 1) => {
  const factor = Math.pow(10, decimals);
  const rounded = Math.round(val * factor) / factor;
  if (unit === '%') {
    return `${(rounded * 100).toFixed(decimals)}%`;
  }
  return `${rounded.toFixed(decimals)}${unit ?? ''}`;
};

src/screens/novel/components/EpubIconButton.tsx (1)

113-121: Quote and escape JS string literals (pluginId, novelName).

If pluginId is a string (e.g., "lightnovelcave"), let sourceId =${novel.pluginId}; produces invalid JS. Also, novel.name may contain quotes and break the template. Use JSON.stringify to safely embed.

-        let novelName = "${novel.name}";
+        let novelName = ${JSON.stringify(novel.name)};
         let chapterName = "";
-        let sourceId =${novel.pluginId};
+        let sourceId = ${JSON.stringify(novel.pluginId)};
         let chapterId ="";
         let novelId =${novel.id};
         let html = document.querySelector("chapter").innerHTML;

src/navigators/Main.tsx (1)

114-121: Broken deep link: target screen removed.

Linking config references RespositorySettings: '/repo/add', but this screen no longer exists in SettingsStack. Deep links to /repo/add will fail.

Fix by either:

• Reintroducing a route that handles repository add (e.g., SubScreen with appropriate params), and update linking accordingly, or
• Removing the linking entry.

Example:

-                    RespositorySettings: '/repo/add',
+                    SubScreen: '/repo/add',

Ensure SettingsSubScreen handles the repo flow.

src/screens/reader/ReaderScreen.tsx (1)

81-93: Fix null access in injected WebView script when pageReader is enabled

document.querySelector('chapter') may be null (common markup uses #LNReader-chapter). This can throw and break navigation.

Apply:

-          : `(()=>{
-              document.querySelector('chapter').setAttribute('data-page',0);
-              document.querySelector("chapter").style.transform = 'translate(0%)';
-            })()`,
+          : `(()=>{
+              const el = document.querySelector('#LNReader-chapter, chapter');
+              if (!el) return;
+              el.setAttribute('data-page', 0);
+              el.style.transform = 'translate(0%)';
+            })()`,

src/screens/library/components/LibraryBottomSheet/LibraryBottomSheet.tsx (2)

51-69: FlashList items won’t update when downloadedOnlyMode changes

disabled depends on downloadedOnlyMode but it’s not in extraData, so toggling won’t re-render rows.

-      <FlashList
-        extraData={[filter]}
+      <FlashList
+        extraData={[filter, downloadedOnlyMode]}

---

155-165: FlashList items won’t update when badge toggles change

Only displayMode is in extraData, so the three Checkbox rows may not reflect state changes.

-      <FlashList
-        data={displayModesList}
-        extraData={[displayMode]}
+      <FlashList
+        data={displayModesList}
+        extraData={[displayMode, showDownloadBadges, showUnreadBadges, showNumberOfNovels]}

src/screens/settings/dynamic/components/TextToSpeechSettings.tsx (1)

79-91: Fix potential crash when tts is undefined and avoid uncontrolled Slider values; also clamp to Expo Speech ranges.

• value={tts?.rate} / value={tts?.pitch} can be undefined (first render or corrupted state), making Slider uncontrolled; onSlidingComplete spreads ...tts which will throw if tts is undefined.
• Expo Speech rate should be 0–1 and pitch typically 0.5–2; current maxima (5) allow invalid values.

Apply:

-            <Slider
-              style={styles.slider}
-              value={tts?.rate}
-              minimumValue={0.1}
-              maximumValue={5}
-              step={0.1}
+            <Slider
+              style={styles.slider}
+              value={tts?.rate ?? 1}
+              minimumValue={0.1}
+              maximumValue={1}
+              step={0.05}
               minimumTrackTintColor={theme.primary}
               maximumTrackTintColor={theme.surfaceVariant}
               thumbTintColor={theme.primary}
-              onSlidingComplete={value =>
-                setChapterReaderSettings({ tts: { ...tts, rate: value } })
-              }
+              onSlidingComplete={value =>
+                setChapterReaderSettings({
+                  tts: {
+                    pitch: tts?.pitch ?? 1,
+                    rate: value,
+                    voice: tts?.voice,
+                  },
+                })
+              }
             />

-            <Slider
-              style={styles.slider}
-              value={tts?.pitch}
-              minimumValue={0.1}
-              maximumValue={5}
-              step={0.1}
+            <Slider
+              style={styles.slider}
+              value={tts?.pitch ?? 1}
+              minimumValue={0.5}
+              maximumValue={2}
+              step={0.1}
               minimumTrackTintColor={theme.primary}
               maximumTrackTintColor={theme.surfaceVariant}
               thumbTintColor={theme.primary}
-              onSlidingComplete={value =>
-                setChapterReaderSettings({ tts: { ...tts, pitch: value } })
-              }
+              onSlidingComplete={value =>
+                setChapterReaderSettings({
+                  tts: {
+                    pitch: value,
+                    rate: tts?.rate ?? 1,
+                    voice: tts?.voice,
+                  },
+                })
+              }
             />

Also applies to: 95-107

src/screens/library/LibraryScreen.tsx (1)

340-351: Fix “Update Category” action using novels array instead of categories.

library[index] references a novel, not the selected category. This triggers wrong IDs/names and can crash.

-          {
-            title: getString('libraryScreen.extraMenu.updateCategory'),
-            onPress: () =>
-              //2 = local category
-              library[index].id !== 2 &&
-              ServiceManager.manager.addTask({
-                name: 'UPDATE_LIBRARY',
-                data: {
-                  categoryId: library[index].id,
-                  categoryName: library[index].name,
-                },
-              }),
-          },
+          {
+            title: getString('libraryScreen.extraMenu.updateCategory'),
+            onPress: () =>
+              // 2 = local category
+              categories[index] &&
+              categories[index].id !== 2 &&
+              ServiceManager.manager.addTask({
+                name: 'UPDATE_LIBRARY',
+                data: {
+                  categoryId: categories[index].id,
+                  categoryName: categories[index].name,
+                },
+              }),
+          },