Split /entity/{etype} for performance reasons.
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added endpoint to get only documents. - Added endpoint to get only count. - Deprecated original endpoint.
0a8cc35 to
61dd0de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal PR to split the
/entity/{etype}endpoint into two parts. The endpoint performs two queries, fetching paged documents and counting total number of documents matching the query. While convenient, counting all documents can become expensive on large databases, so it shouldn't be done on every page fetch.The proposal introduces two new endpoints to perform the two actions separately.
/entity{etype}/get- fetching the snapshot list according to query/entity{etype}/count- counting all snapshot documents according to query.