DB: fix access to master buffers during DP insertion #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to master buffers during datapoint insertion sometimes results in `KeyError` causing termination of worker thread. Eventually, error "Thread X is dead, more than 20 restarts attempted, giving up..." appears, worker termination procedure gets invoked, but ends up with infinite logging of "N worker threads alive". The result is silent failure of the whole worker and no task processing.
xsedla1o
approved these changes
Sep 16, 2025
Collaborator
xsedla1o
left a comment
There was a problem hiding this comment.
Nice catch, thank you for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to master buffers during datapoint insertion sometimes results in
KeyErrorcausing termination of worker thread. Eventually, error "Thread X is dead, more than 20 restarts attempted, giving up..." appears, worker termination procedure gets invoked, but ends up with infinite logging of "N worker threads alive". The result is silent failure of the whole worker and no task processing. This situation needs further investigation, but I'm at least providing a fix.