TaskDistributor: Ensure process shutdown #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with hanging threads that prevent proper application shutdown by implementing a bounded graceful shutdown mechanism. When the TaskDistributor fails to shutdown within 60 seconds, it forces process termination and provides diagnostic information.
- Adds timeout-bounded worker thread joining during shutdown
- Implements forced process termination with
os._exit()when graceful shutdown fails - Provides diagnostic thread stack dumps for post-mortem analysis
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3aa2d7d to
2129365
Compare
Collaborator
|
Nice patch! Hopefully no more silent lockups of DP³. |
dbnk0
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues with hanging threads that block the application shutdown.
Typically, when an unexpected error that we cannot recover from happens, we would like the app to shutdown and be completely restarted by the supervisor process. On rare occasions however, worker threads can get stuck and the app may hang indefinitely until killed by an administrator.
Now, when the graceful shutdown after failure does not complete within 60 seconds,
TaskDistributorwill force the entire process to quit usingos._exit(), and stack traces will be printed for all threads to help diagnose problems post-mortem.