Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ahouseholder
Copy link
Contributor

doctools.py wasn't importing all the DecisionTable object it should have been, which means it wasn't generating expected .json example files. This PR fixes that.

Copilot Summary

This pull request removes several unused decision point JSON files and updates the documentation tooling to include decision tables in the import process. It also renames a decision table file for consistency and makes a minor update to its metadata.

Removals of unused decision point definitions:

  • Deleted the following unused decision point JSON files from data/json/decision_points/x_basic/ and data/json/decision_points/x_community/:
    • do_schedule_delegate_delete_1_0_0.json
    • moscow_1_0_0.json
    • value_complexity_1_0_0.json
    • yes_no_1_0_0.json
    • theparanoids_1_0_0.json

Documentation tooling improvements:

  • Updated src/ssvc/doctools.py to include decision tables in the import process by adding a call to find_modules_to_import for the decision_tables directory.

File renaming and metadata update:

  • Renamed cisa_coordinate_dt_2_0_3.json to cisa_coordinator_2_0_3.json and updated the "name" field to "CISA Coordinator" for consistency.

also cleans up some older cruft from before `x_basic` moved to `basic` namespace
@ahouseholder ahouseholder added this to the 2025-09 milestone Aug 7, 2025
@ahouseholder ahouseholder self-assigned this Aug 7, 2025
@ahouseholder ahouseholder added the bug Something isn't working label Aug 7, 2025
@ahouseholder ahouseholder linked an issue Aug 7, 2025 that may be closed by this pull request
@ahouseholder ahouseholder added tech/backend Back-end tools, code, infrastructure tech/data Data implementation (content of /data, data object instances, etc.) labels Aug 7, 2025
Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ahouseholder ahouseholder merged commit 86db116 into main Aug 7, 2025
4 checks passed
@ahouseholder ahouseholder deleted the fix-855 branch August 7, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tech/backend Back-end tools, code, infrastructure tech/data Data implementation (content of /data, data object instances, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doctools.py might not be importing decision tables correctly

3 participants